Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bwc tests for 2.5.0 #661

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

jmazanec15
Copy link
Member

Description

Updates rolling bwc to 2.5.0 and restart bwc to include 2.5.0.

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <[email protected]>
@jmazanec15 jmazanec15 requested a review from a team December 8, 2022 22:07
Signed-off-by: John Mazanec <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #661 (c557c27) into main (79ae6c2) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #661      +/-   ##
============================================
- Coverage     84.80%   84.47%   -0.33%     
+ Complexity     1055     1050       -5     
============================================
  Files           149      149              
  Lines          4291     4291              
  Branches        379      379              
============================================
- Hits           3639     3625      -14     
- Misses          477      489      +12     
- Partials        175      177       +2     
Impacted Files Coverage Δ
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 60.00% <0.00%> (-20.00%) ⬇️
...org/opensearch/knn/training/TrainingJobRunner.java 49.25% <0.00%> (-4.48%) ⬇️
...ain/java/org/opensearch/knn/index/KNNSettings.java 80.88% <0.00%> (-2.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jmazanec15
Copy link
Member Author

Blocked by opensearch-project/opensearch-build#2984

Signed-off-by: John Mazanec <[email protected]>
@jmazanec15
Copy link
Member Author

@martin-gaievski @navneet1v Could I get a review? Whitesource check is failing for unrelated error to this PR. I believe issue is in nmslib with a feature we dont use. I will open up an issue to track that.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx Jack

@martin-gaievski martin-gaievski merged commit 01e1c7f into opensearch-project:main Dec 12, 2022
@jmazanec15 jmazanec15 added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants