Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build script to build JNI lib and gradlew assemble #659

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen [email protected]

Description

Update build script to build JNI libraries separately and then do gradle assemble instead of gradle build

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda requested a review from a team December 7, 2022 22:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #659 (6cca564) into 1.3 (b6f89a1) will increase coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #659      +/-   ##
============================================
+ Coverage     83.91%   84.27%   +0.36%     
- Complexity      895      901       +6     
============================================
  Files           127      127              
  Lines          3867     3867              
  Branches        358      358              
============================================
+ Hits           3245     3259      +14     
+ Misses          463      451      -12     
+ Partials        159      157       -2     
Impacted Files Coverage Δ
...ain/java/org/opensearch/knn/index/KNNSettings.java 83.08% <0.00%> (+2.20%) ⬆️
...org/opensearch/knn/training/TrainingJobRunner.java 53.73% <0.00%> (+4.47%) ⬆️
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 80.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveentatikonda naveentatikonda added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.3.7 labels Dec 7, 2022
@naveentatikonda naveentatikonda merged commit 9f22a6a into 1.3 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants