Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Add fix to fromXContent and toXContent in ModelGraveyard #624

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f92651b from #618

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team November 10, 2022 22:22
@jmazanec15
Copy link
Member

@naveentatikonda CI is fixed. Can you rebase so CI passes?

* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit f92651b)
@naveentatikonda naveentatikonda force-pushed the backport/backport-618-to-main branch from f541619 to 825fb2a Compare December 14, 2022 02:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #624 (825fb2a) into main (6ba2b5d) will increase coverage by 0.23%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #624      +/-   ##
============================================
+ Coverage     84.48%   84.72%   +0.23%     
- Complexity     1051     1060       +9     
============================================
  Files           149      149              
  Lines          4292     4307      +15     
  Branches        379      385       +6     
============================================
+ Hits           3626     3649      +23     
+ Misses          489      480       -9     
- Partials        177      178       +1     
Impacted Files Coverage Δ
...ava/org/opensearch/knn/indices/ModelGraveyard.java 90.27% <75.00%> (-2.71%) ⬇️
...ain/java/org/opensearch/knn/index/KNNSettings.java 83.08% <0.00%> (+2.20%) ⬆️
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 80.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveentatikonda naveentatikonda merged commit 9e79efc into main Dec 14, 2022
@naveentatikonda naveentatikonda deleted the backport/backport-618-to-main branch December 14, 2022 17:41
@jmazanec15 jmazanec15 added the Bug Fixes Changes to a system or product designed to handle a programming bug/glitch label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants