-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial faiss interface support #42
Merged
jmazanec15
merged 14 commits into
opensearch-project:feature/faiss-support
from
jmazanec15:initial-faiss-interface
Jun 29, 2021
Merged
Initial faiss interface support #42
jmazanec15
merged 14 commits into
opensearch-project:feature/faiss-support
from
jmazanec15:initial-faiss-interface
Jun 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
…er merge from failing Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
vamshin
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. LGTM! Thanks
…/k-NN into initial-faiss-interface
…1 into initial-faiss-interface
VijayanB
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Jun 30, 2021
commit c9a3566 Author: Jack Mazanec <[email protected]> Date: Tue Jun 29 15:38:39 2021 -0700 Initial faiss interface support (opensearch-project#42) Signed-off-by: John Mazanec <[email protected]> Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Oct 22, 2021
Signed-off-by: Jack Mazanec <[email protected]>
jmazanec15
added a commit
that referenced
this pull request
Oct 22, 2021
Signed-off-by: Jack Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: Jack Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: Jack Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Jack Mazanec <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds initial support through the
knn_vector
field type for faiss. This PR allows users to use HNSW method with flat encoding:In the future, we will add more methods.
The main changes include adding a MethodComponentContext parameter type, so that components such as encoders, may be configured through parameters, logic to build custom map of parameters including index description to be passed to faiss library, mapper interface changes, etc.
Additionally, added/refactored tests to better cover initial functionality.
Issues Resolved
#27
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.