Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tests.security.manager flag to false in integTestRemote task #410

Conversation

martin-gaievski
Copy link
Member

Signed-off-by: Martin Gaievski [email protected]

Description

Currently default command for running integTests doesn't work because core OS can't set security manager properly. This happens for the plugin while setting read-only property that has been already set for core OS

 Caused by:
        java.lang.IllegalStateException: codebase property already set: codebase.opensearch-knn -> file:/Users/gaievski/dev/opensearch/k-NN/build/distributions/opensearch-knn-2.0.0.0-SNAPSHOT-test-fixtures.jar, cannot set to file:/Users/gaievski/dev/opensearch/k-NN/build/distributions/opensearch-knn-2.0.0.0-SNAPSHOT.jar
            at org.opensearch.bootstrap.Security.readPolicy(Security.java:248)
            at org.opensearch.bootstrap.BootstrapForTesting.<clinit>(BootstrapForTesting.java:161)

All our test related gradle tasks except for integTestRemote defaulted security.manager flag to false, example. With this change I'm doing the same for integTestRemote so mentioned commands for release checks can work properly. Flag still can be set to true if required, we just changing default value.

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label May 24, 2022
@martin-gaievski martin-gaievski requested a review from a team May 24, 2022 21:32
@martin-gaievski martin-gaievski changed the title Adding tests.security.manager flag to integTestRemote task Set tests.security.manager flag to false in integTestRemote task May 24, 2022
@martin-gaievski martin-gaievski merged commit fc88786 into opensearch-project:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants