Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Lombok #391

Conversation

martin-gaievski
Copy link
Member

Description

Adding support for Lombok library that generates lot of boilerplate Java code via annotations. In addition to reference to library binaries changed one test class to prove that Lombok generated code is visible in runtime.

Issues Resolved

#390

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski requested a review from a team May 10, 2022 01:17
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #391 (b6596f4) into main (e5745de) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #391   +/-   ##
=========================================
  Coverage     84.01%   84.01%           
  Complexity      911      911           
=========================================
  Files           130      130           
  Lines          3879     3879           
  Branches        359      359           
=========================================
  Hits           3259     3259           
  Misses          458      458           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5745de...b6596f4. Read the comment docs.

@naveentatikonda
Copy link
Member

@martin-gaievski Can you rebase the commits and remove commits(adding release notes for 2.0 rc1) not related to this PR

@martin-gaievski
Copy link
Member Author

martin-gaievski commented May 11, 2022

@martin-gaievski Can you rebase the commits and remove commits(adding release notes for 2.0 rc1) not related to this PR

I see, I think this branch may be created not from the main one. I'll probably re-create PR and close this one

@naveentatikonda - created a new PR with clean branch history #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants