[Backport 1.2] Allow null value for params in method mappings #357
+117
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to input null value for parameters field for KNNMethodContext and MethodComponentContext. Adds tests to reproduce Mapping Parsing Error when the parameters take the value null as well as BWC tests. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit b08127c)
|
BWC tests were not introduced until after 1.2 so they could not be backported back. |
Codecov Report
@@ Coverage Diff @@
## 1.2 #357 +/- ##
============================================
+ Coverage 83.19% 83.31% +0.11%
- Complexity 864 875 +11
============================================
Files 123 123
Lines 3779 3799 +20
Branches 358 363 +5
============================================
+ Hits 3144 3165 +21
+ Misses 475 474 -1
Partials 160 160
Continue to review full report at Codecov.
|
martin-gaievski
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to input null value for parameters field for KNNMethodContext
and MethodComponentContext. Adds tests to reproduce Mapping Parsing Error when the parameters take
the value null as well as BWC tests.
Backport: #354
Signed-off-by: John Mazanec [email protected]
(cherry picked from commit b08127c)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.