[Backport 1.x] Allow null value for params in method mappings #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Allow user to input null value for parameters field for KNNMethodContext and MethodComponentContext. Adds tests to reproduce Mapping Parsing Error when the parameters take the value null as well as BWC tests. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit b08127c)
Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.x #355 +/- ##
============================================
+ Coverage 83.41% 83.47% +0.05%
- Complexity 889 895 +6
============================================
Files 127 127
Lines 3841 3854 +13
Branches 361 366 +5
============================================
+ Hits 3204 3217 +13
Misses 475 475
Partials 162 162
Continue to review full report at Codecov.
|
martin-gaievski
approved these changes
Apr 7, 2022
naveentatikonda
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b08127c from #354