Adding documentation on codec versioning #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
Documentation
naveentatikonda
previously approved these changes
Mar 29, 2022
| @@ -265,6 +265,26 @@ Here, we are testing BWC Tests with BWC version of plugin as 1.0.0.0. Make sure | |||
|
|
|||
| Before adding any new tests to Backward Compatibility Tests, we should be aware that the tests in BWC are not independent. While creating an index, a test cannot use the same index name if it is already used in other tests. Also, adding extra operations to the existing test may impact other existing tests like graphCount. | |||
|
|
|||
| ## Codec Versioning | |||
There was a problem hiding this comment.
Can you add this(with a hyperlink) to the index on the top of this file ?
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
update-docs-on-codec-versioning
branch
from
9f85255 to
db15e81
Compare
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
=========================================
Coverage 83.99% 83.99%
Complexity 900 900
=========================================
Files 130 130
Lines 3854 3854
Branches 353 353
=========================================
Hits 3237 3237
Misses 457 457
Partials 160 160 Continue to review full report at Codecov.
|
naveentatikonda
approved these changes
Mar 29, 2022
junqiu-lei
approved these changes
Mar 30, 2022
martin-gaievski
added a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Gaievski [email protected]
Description
Put description of new versioning for codecs from PR description #328 to dev guide.
Issues Resolved
No master issue yet, aiming 2.0 release
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.