Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JDK 17 to CI #322

Merged

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Mar 17, 2022

Signed-off-by: Martin Gaievski [email protected]

Description

Adding JDK17 support - added JDK17 to CI matrix, updated developer guide with note of support

Issues Resolved

#312

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #322 (e7cd549) into main (580411e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #322   +/-   ##
=========================================
  Coverage     83.49%   83.49%           
  Complexity      889      889           
=========================================
  Files           127      127           
  Lines          3829     3829           
  Branches        361      361           
=========================================
  Hits           3197     3197           
  Misses          470      470           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580411e...e7cd549. Read the comment docs.

@jmazanec15
Copy link
Member

Why is it in draft state @martin-gaievski?

@martin-gaievski martin-gaievski changed the title Adding jdk 17 to CI Adding JDK 17 to CI Mar 17, 2022
Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski
Copy link
Member Author

Why is it in draft state @martin-gaievski?

I'm adding some doc changes, draft is mainly to submit CI build job for JDK 17

@martin-gaievski martin-gaievski added v2.0.0 Enhancements Increases software capabilities beyond original client specifications labels Mar 17, 2022
@martin-gaievski martin-gaievski self-assigned this Mar 17, 2022
@martin-gaievski martin-gaievski marked this pull request as ready for review March 17, 2022 16:39
@martin-gaievski martin-gaievski requested a review from a team March 17, 2022 16:39
@martin-gaievski martin-gaievski merged commit ccbc0db into opensearch-project:main Mar 17, 2022
@martin-gaievski martin-gaievski deleted the adding-jdk17-support branch March 17, 2022 17:05
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants