-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.x] [BUG FIX] Fix knn index shard to get bwc engine paths #310
Conversation
Fixes getEnginePaths in KNNIndexShard to retrieve all engine paths, regardless of what version the index was created. Prevents silent failure when warmup completes but doesnt load any segments. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit bb28393)
Codecov Report
@@ Coverage Diff @@
## 1.x #310 +/- ##
============================================
+ Coverage 83.38% 83.49% +0.10%
- Complexity 885 889 +4
============================================
Files 127 127
Lines 3834 3829 -5
Branches 361 361
============================================
Hits 3197 3197
+ Misses 475 470 -5
Partials 162 162
Continue to review full report at Codecov.
|
Signed-off-by: John Mazanec <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-310-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 54d974cda4f8e86d6ef993d7702b08f1f00338a3
# Push it to GitHub
git push --set-upstream origin backport-310-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2 Then, create a pull request where the |
…ject#310) Fixes getEnginePaths in KNNIndexShard to retrieve all engine paths, regardless of what version the index was created. Prevents silent failure when warmup completes but doesnt load any segments. Signed-off-by: John Mazanec <[email protected]>
…ject#310) Fixes getEnginePaths in KNNIndexShard to retrieve all engine paths, regardless of what version the index was created. Prevents silent failure when warmup completes but doesnt load any segments. Signed-off-by: John Mazanec <[email protected]>
Backport bb28393 from #309