Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy version to 1.22 #304

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Mar 3, 2022

Signed-off-by: Martin Gaievski [email protected]

Description

Bump numpy version to 1.22.0rc1 per requirements in GHSA-f7c7-j99h-c22f. Tested it locally, it works with Python 3.8+

Issues Resolved

#280 #281

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski
Copy link
Member Author

I think we can overwrite the failing checks - it refer to a past commit 2fb2ad1 and recent change has overwritten that.

@martin-gaievski martin-gaievski marked this pull request as ready for review March 3, 2022 20:56
@martin-gaievski martin-gaievski requested a review from a team March 3, 2022 20:56
@martin-gaievski martin-gaievski added v1.3.0 Issues and PRs related to version 1.3.0 security fix Security fix generated by WhiteSource labels Mar 3, 2022
@jmazanec15
Copy link
Member

Why cant I get this on my mac? Does this mean we just dont support python 3.7?

pip3 install numpy==1.22.1
ERROR: Could not find a version that satisfies the requirement numpy==1.22.1 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0rc1, 1.15.0rc2, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0rc1, 1.16.0rc2, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0rc1, 1.17.0rc2, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0rc1, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1, 1.19.0rc2, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0rc1, 1.20.0rc2, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0rc1, 1.21.0rc2, 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5)
ERROR: No matching distribution found for numpy==1.22.1

pip3 --version
pip 22.0.3 from /Users/jmazane/.pyenv/versions/3.7.9/lib/python3.7/site-packages/pip (python 3.7)

@martin-gaievski
Copy link
Member Author

martin-gaievski commented Mar 3, 2022

Why cant I get this on my mac? Does this mean we just dont support python 3.7?

pip3 install numpy==1.22.1
ERROR: Could not find a version that satisfies the requirement numpy==1.22.1 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0rc1, 1.15.0rc2, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0rc1, 1.16.0rc2, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0rc1, 1.17.0rc2, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0rc1, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1, 1.19.0rc2, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0rc1, 1.20.0rc2, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0rc1, 1.21.0rc2, 1.21.0, 1.21.1, 1.21.2, 1.21.3, 1.21.4, 1.21.5)
ERROR: No matching distribution found for numpy==1.22.1

pip3 --version
pip 22.0.3 from /Users/jmazane/.pyenv/versions/3.7.9/lib/python3.7/site-packages/pip (python 3.7)

Yes, the official release of 1.22.x dropped support for python 3.7 - https://numpy.org/doc/stable/release/1.22.0-notes.html#python-3-7-is-no-longer-supported. Works for me on mac after upgrade to 3.9

@martin-gaievski martin-gaievski merged commit fe22b85 into opensearch-project:1.x Mar 3, 2022
@martin-gaievski martin-gaievski added Mend: dependency security vulnerability Security vulnerability detected by WhiteSource and removed security fix Security fix generated by WhiteSource labels Mar 4, 2022
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mend: dependency security vulnerability Security vulnerability detected by WhiteSource v1.3.0 Issues and PRs related to version 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants