[FLAKY TEST] Fix codec test causing CI to fail #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes resource monitor at the end of the tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
| @@ -109,7 +109,8 @@ public void testFooter(Codec codec) throws Exception { | |||
| doc.add(vectorField); | |||
| writer.addDocument(doc); | |||
|
|
|||
| NativeMemoryLoadStrategy.IndexLoadStrategy.initialize(createDisabledResourceWatcherService()); | |||
| ResourceWatcherService resourceWatcherService = createDisabledResourceWatcherService(); | |||
| NativeMemoryLoadStrategy.IndexLoadStrategy.initialize(resourceWatcherService); | |||
There was a problem hiding this comment.
It seems that the only change in these lines is related to improved code readability, is this correct?
There was a problem hiding this comment.
I did it to be able to close resourceWatcherService at the end.
There was a problem hiding this comment.
Oh, I see, that makes sense. Thank you Jack
martin-gaievski
approved these changes
Feb 10, 2022
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Feb 10, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
jmazanec15
pushed a commit
that referenced
this pull request
Feb 10, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
jmazanec15
pushed a commit
that referenced
this pull request
Feb 10, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
… (opensearch-project#286) Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
… (opensearch-project#286) Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35) Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 31, 2022
… (opensearch-project#286) Closes resource monitor at the end of the Codec tests so that there are no unparked threads. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 18e6e35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI keeps failing because of our Codec tests: https://github.com/opensearch-project/k-NN/actions/runs/1820922609. It is due to threads leaking. This PR closes a 2 closeables that were causing an issue: IndexLoadStrategy, resourceWatcherService.
CI was able to pass on my fork: https://github.com/jmazanec15/k-NN-1/actions/runs/1821011151.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.