-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JDK 11 to CI and docs #271
Adding JDK 11 to CI and docs #271
Conversation
Signed-off-by: Martin Gaievski <[email protected]>
Thanks @martin-gaievski. For 8 and 17, would you be able to post the relevant stack traces in the issue? |
Sure, for JDK 8 it's OS, seems it has been compiled with JDK 9:
https://github.com/martin-gaievski/k-NN/runs/4945583353?check_suite_focus=true for JDK 17 higher gradle version is required, I've tested with 7.3.3. It fails with
https://github.com/opensearch-project/k-NN/runs/4957612326?check_suite_focus=true I've dropped email to Daniel, haven't got an answer yet. |
Thanks @martin-gaievski Please paste those in #220 so we can continue discussion there. |
sure, added same comment to the issue |
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS. Signed-off-by: Martin Gaievski <[email protected]>
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS. Signed-off-by: Martin Gaievski <[email protected]>
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS. Signed-off-by: Martin Gaievski <[email protected]>
Description
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS. For now I couldn't make JDK 8 and 17 work, plugin build has multiple issues with each of those versions.
Issues Resolved
#220
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.