Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JDK 11 to CI and docs #271

Merged

Conversation

martin-gaievski
Copy link
Member

Description

Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS. For now I couldn't make JDK 8 and 17 work, plugin build has multiple issues with each of those versions.

Issues Resolved

#220

Check List

  • New functionality has been documented.
    • New functionality has section in md file(s)
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
@jmazanec15
Copy link
Member

Thanks @martin-gaievski. For 8 and 17, would you be able to post the relevant stack traces in the issue?

@martin-gaievski
Copy link
Member Author

Thanks @martin-gaievski. For 8 and 17, would you be able to post the relevant stack traces in the issue?

Sure, for JDK 8 it's OS, seems it has been compiled with JDK 9:

org/opensearch/gradle/plugin/PluginPropertiesExtension has been compiled by a more recent version of the Java Runtime (class file version 54.0), this version of the Java Runtime only recognizes class file versions up to 52.0

https://github.com/martin-gaievski/k-NN/runs/4945583353?check_suite_focus=true

for JDK 17 higher gradle version is required, I've tested with 7.3.3. It fails with

Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/cli/CommandLineParser
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:43)

https://github.com/opensearch-project/k-NN/runs/4957612326?check_suite_focus=true
I've tried multiple things locally - different gradle versions, generating new gradle wrapper, setting java language level for tooling etc., but no success.

I've dropped email to Daniel, haven't got an answer yet.

@jmazanec15
Copy link
Member

Thanks @martin-gaievski

Please paste those in #220 so we can continue discussion there.

@martin-gaievski martin-gaievski marked this pull request as ready for review January 27, 2022 22:01
@martin-gaievski martin-gaievski requested a review from a team January 27, 2022 22:01
@martin-gaievski
Copy link
Member Author

Thanks @martin-gaievski

Please paste those in #220 so we can continue discussion there.

sure, added same comment to the issue

@martin-gaievski martin-gaievski requested review from junqiu-lei and a team January 27, 2022 22:10
@martin-gaievski martin-gaievski merged commit 7e9d4c5 into opensearch-project:main Jan 27, 2022
@martin-gaievski martin-gaievski added v1.3.0 Issues and PRs related to version 1.3.0 Enhancements Increases software capabilities beyond original client specifications labels Jan 31, 2022
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS.

Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS.

Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Adding JDK 11 to CI matrix of java versions, replacing as minimum prerequisite in Dev readme guide. Main reason for change - JDK 11 is the latest supported LTS.

Signed-off-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications v1.3.0 Issues and PRs related to version 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants