[Draft] Implement getCustomCodecService for EnginePlugin #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added
the
Bug Fixes
jmazanec15
requested review from
nknize,
VijayanB,
vamshin,
naveentatikonda and
a team
naveentatikonda
approved these changes
Nov 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
============================================
- Coverage 83.21% 83.00% -0.21%
+ Complexity 864 859 -5
============================================
Files 123 122 -1
Lines 3777 3766 -11
Branches 358 358
============================================
- Hits 3143 3126 -17
- Misses 474 479 +5
- Partials 160 161 +1
Continue to review full report at Codecov.
|
jmazanec15
commented
Nov 23, 2021
|
|
||
| @Override | ||
| public Engine newReadWriteEngine(EngineConfig config) { | ||
| codecService.setPostingsFormat(config.getCodec().postingsFormat()); |
There was a problem hiding this comment.
Good catch. We would need this line otherwise it could be a breaking change. Reason for explicitly setting this is documented in PR opendistro-for-elasticsearch/k-NN#236
There was a problem hiding this comment.
Moving PR into draft state for now. I think we can refactor this a little bit.
jmazanec15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Mazanec [email protected]
Description
This PR implements the
getCustomCodecServicefunction of the EnginePlugin interface. That way, we do not have to override the entire engine factory for indices that use k-NN, just the CodecService. This will allow k-NN to be used with CCR plugin.Issues Resolved
#147
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.