Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change googletest from master to main #212

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

jmazanec15
Copy link
Member

Signed-off-by: John Mazanec [email protected]

Description

Backport 211 to 1.2

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jmazanec15 jmazanec15 added the Bug Fixes Changes to a system or product designed to handle a programming bug/glitch label Nov 15, 2021
@jmazanec15 jmazanec15 changed the title Change googletest from master to main (#211) Change googletest from master to main Nov 15, 2021
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15 jmazanec15 removed the request for review from VijayanB November 15, 2021 21:37
@jmazanec15 jmazanec15 merged commit 079dddd into opensearch-project:1.2 Nov 15, 2021
@peternied
Copy link
Member

Since this is a release branch, would it make sense to point to a release like https://github.com/google/googletest/releases/tag/release-1.11.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Changes to a system or product designed to handle a programming bug/glitch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants