-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix field validation in VectorReader #207
Fix field validation in VectorReader #207
Conversation
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
============================================
+ Coverage 83.10% 83.26% +0.15%
- Complexity 861 864 +3
============================================
Files 123 123
Lines 3771 3777 +6
Branches 361 358 -3
============================================
+ Hits 3134 3145 +11
+ Misses 475 471 -4
+ Partials 162 161 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Description
This PR fixes the bug when training data index shard is not on training node. It uses the validation logic used in training model request in VectorReader. Additionally, for VectorReader, IndicesService is swapped out with ClusterService.
Lastly, this PR adds a couple error increments in TrainingJob that were not getting picked up.
Issues Resolved
#205
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.