-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add training stats and library initialized stats #191
Conversation
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
============================================
- Coverage 83.16% 83.08% -0.09%
- Complexity 846 858 +12
============================================
Files 122 123 +1
Lines 3706 3759 +53
Branches 358 359 +1
============================================
+ Hits 3082 3123 +41
- Misses 465 475 +10
- Partials 159 161 +2
Continue to review full report at Codecov.
|
Signed-off-by: John Mazanec <[email protected]>
src/main/java/org/opensearch/knn/index/memory/NativeMemoryCacheManager.java
Outdated
Show resolved
Hide resolved
routeRequest(request, listener); | ||
}, listener::onFailure)); | ||
routeRequest(request, wrappedListener); | ||
}, wrappedListener::onFailure)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, wrappedListener::onFailure)); | |
}, ex-> { | |
KNNCounter.TRAINING_ERRORS.increment(); | |
listener.onFailure(ex); | |
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In its new location, I think it makes sense to be a variable
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
) Signed-off-by: John Mazanec <[email protected]>
) Signed-off-by: John Mazanec <[email protected]>
) Signed-off-by: John Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
) Signed-off-by: John Mazanec <[email protected]>
Description
This change adds the last couple of stats for 1.2 release:
It does not take fine grained training job stats (i.e. how much memory a particular training job is using on a node). This is okay because at the moment only one job can execute training on a node at a time. This could be improved in the future.
Stats API response now looks like this:
Issues Resolved
#151
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.