Removes benchmark folder from 2.x branch to resolve CVEs coming from the folder

[shatejas]

Description

Addressing advisories https://advisories.aws.barahmand.com/vulnerabilities/k-NN:%20OpenSearch%20Plugin/origin/main

Related Issues

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[VijayanB]

LGTM.

[heemin32]

Are the CVEs coming only from 2.x branch but not main branch? How is that?

[VijayanB]

Are the CVEs coming only from 2.x branch but not main branch? How is that?

@heemin32 You are right. The CVEs are at both main and 2.x. I believe, during release we have strict guideline that no CVEs should be present. Ideally we should fix at main and backport. However, given the issues are with benchmarks/* ( not part of k-nn and they won't be shipped with product ) and imo, we don't need this code at 2.x branch , so it is safe to delete from 2.x branch. We are also working on permanently moving all features from this folder to OSB, so that we can remove from main itself.

[shatejas]

Are the CVEs coming only from 2.x branch but not main branch? How is that?

I did not remove it as perf test are needed during release testing. Can remove it once osb is ready

[heemin32]

As long as we are also going to remove benchmark folder from main as well I am fine.

[navneet1v]

@shatejas lets port this PR to main branch too, if not already done.

[naveentatikonda]

@shatejas Shouldn't we backport this PR to 2.16 branch to fix the CVEs in 2.16 ?