Add caching of java classes/methods #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=========================================
Coverage 82.78% 82.78%
Complexity 826 826
=========================================
Files 120 120
Lines 3631 3631
Branches 342 342
=========================================
Hits 3006 3006
Misses 468 468
Partials 157 157 Continue to review full report at Codecov.
|
vamshin
reviewed
Nov 6, 2021
| @@ -195,7 +195,7 @@ jobjectArray knn_jni::nmslib_wrapper::QueryIndex(knn_jni::JNIUtilInterface * jni | |||
| int resultSize = neighbors->Size(); | |||
|
|
|||
| jclass resultClass = jniUtil->FindClass(env,"org/opensearch/knn/index/KNNQueryResult"); | |||
| jmethodID allArgs = jniUtil->FindMethod(env, resultClass, "<init>", "(IF)V"); | |||
| jmethodID allArgs = jniUtil->FindMethod(env, "org/opensearch/knn/index/KNNQueryResult", "<init>"); | |||
There was a problem hiding this comment.
Is this intended? We seem to still keep the class name?
There was a problem hiding this comment.
Yes, FindMethod is a wrapper defined in JNIUtil. We pass it the class name and the method name and it finds the method in the map.
VijayanB
approved these changes
Nov 6, 2021
1 task
jmazanec15
added
the
Enhancements
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Mazanec [email protected]
Description
This PR adds Java class and method caching to both JNI libraries. FindClass/FindMethod functions can be expensive calls from C++ layer, so it is recommended to cache these values. For caching implementation, I followed this SO post answer. From a high level, the JNI_onLoad and JNI_onUnload methods will be called when the library is loaded/unloaded by the JVM. Here, we call an initialization function which sets up the caches.
gradle tests as well as google tests both pass.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.