Add IllegalArgumentException for Lucene radial search with ef_search #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
9f5bdf4 to
2744953
Compare
|
The CI failure in |
shatejas
reviewed
Jun 17, 2024
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
e008711 to
515f47e
Compare
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
515f47e to
688b70d
Compare
shatejas
reviewed
Jun 18, 2024
src/main/java/org/opensearch/knn/validation/ParameterValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/util/EngineSpecificMethodContext.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/util/EngineSpecificMethodContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
7f594a9 to
26ec968
Compare
shatejas
requested changes
Jun 19, 2024
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
0a39e79 to
067cdc6
Compare
ryanbogan
approved these changes
Jun 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ef-search #1765 +/- ##
====================================================
Coverage ? 84.84%
Complexity ? 1517
====================================================
Files ? 184
Lines ? 6196
Branches ? 667
====================================================
Hits ? 5257
Misses ? 662
Partials ? 277 ☔ View full report in Codecov by Sentry. |
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
067cdc6 to
94ba1c8
Compare
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
94ba1c8 to
9c8eab8
Compare
shatejas
approved these changes
Jun 20, 2024
src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
radial-luene-ef-search
branch
from
e57b482 to
4a1c373
Compare
junqiu-lei
merged commit 0c41dc5
into
opensearch-project:feature/ef-search
46 of 51 checks passed
junqiu-lei
added a commit
to junqiu-lei/k-NN
that referenced
this pull request
Jul 3, 2024
…pensearch-project#1765) Signed-off-by: Junqiu Lei <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add IllegalArgumentException for Lucene radial search with ef_search parameter. Context at #1537 (comment)
Issues Resolved
Part of #1537
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.