Return 400 on failed training request #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
============================================
- Coverage 82.66% 82.57% -0.10%
Complexity 803 803
============================================
Files 117 117
Lines 3582 3586 +4
Branches 338 338
============================================
Hits 2961 2961
- Misses 466 470 +4
Partials 155 155
Continue to review full report at Codecov.
|
vamshin
reviewed
Oct 31, 2021
| @@ -82,7 +83,9 @@ public void execute(TrainingJob trainingJob, ActionListener<IndexResponse> liste | |||
| // the number of training jobs that enter this function. Although the training threadpool size will also prevent | |||
| // this, we want to prevent this before we perform any serialization. | |||
| if (!semaphore.tryAcquire()) { | |||
| throw new RejectedExecutionException("Unable to run training job: No training capacity on node."); | |||
| ValidationException exception = new ValidationException(); | |||
| exception.addValidationError("Unable to run training job: No training capacity on node."); | |||
There was a problem hiding this comment.
Is it possible to print node name?
There was a problem hiding this comment.
No, that information is not readily available.
There was a problem hiding this comment.
Should we log the error as log.info?
VijayanB
approved these changes
Nov 1, 2021
naveentatikonda
added
the
Bug Fixes
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR changes validation logic to throw 400 error codes as opposed to 500 errors codes during training.
In RestTrainModelHandler, change parser.text to parser.textOrNull to allow a user to pass in a null string argument. Validation is then done later.
In training request execution, throw a validation exception if there is no training capacity. This results in a 400 error being returned
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.