Support source filtering for model search #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test case to make sure output from get model can be reduced by adding filter_path parameter. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
source-filtering
branch
2 times, most recently
from
cbf2087 to
9224d68
Compare
jmazanec15
reviewed
Oct 28, 2021
| @@ -395,7 +395,10 @@ public void search(SearchRequest request, ActionListener<SearchResponse> actionL | |||
| request.indices(MODEL_INDEX_NAME); | |||
| client.search(request,ActionListener.wrap(response -> { | |||
| for (SearchHit hit : response.getHits()) { | |||
| ToXContentObject xContentObject = Model.getModelFromSourceMap(hit.getSourceAsMap(), hit.getId()); | |||
| if(hit.getSourceAsMap() == null){ | |||
There was a problem hiding this comment.
Im not convinced we need to do anything special here. Why can't we just return the search response directly to the listener? I know we need to add the model_id, but I think it would be better to just add that to the mapping in another PR.
There was a problem hiding this comment.
Removed processing. Now search response will have field called "model_id". This will be updated once model id is added to the mapping parameter.
VijayanB
force-pushed
the
source-filtering
branch
4 times, most recently
from
9714763 to
aa13e10
Compare
VijayanB
added
the
Bug Fixes
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
============================================
- Coverage 82.82% 82.66% -0.16%
- Complexity 801 803 +2
============================================
Files 117 117
Lines 3580 3582 +2
Branches 339 338 -1
============================================
- Hits 2965 2961 -4
- Misses 461 466 +5
- Partials 154 155 +1
Continue to review full report at Codecov.
|
vamshin
reviewed
Oct 29, 2021
| actionListener.onResponse(response); | ||
|
|
||
| }, actionListener::onFailure)); | ||
| client.search(request,actionListener); |
| @@ -105,6 +108,44 @@ public void testGetModelExists() throws IOException { | |||
| assertEquals(testModelMetadata.getTimestamp(), responseMap.get(MODEL_TIMESTAMP)); | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
Return model index search response as output for model search api. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
source-filtering
branch
from
aa13e10 to
7ae6668
Compare
jmazanec15
reviewed
Oct 29, 2021
Comment on lines
+170
to
+171
| ModelMetadata modelMetadata = ModelMetadata.getMetadataFromSourceMap(sourceMap); | ||
| byte[] blob = getModelBlobFromResponse(sourceMap); |
There was a problem hiding this comment.
Want to confirm: what happens if these are null?
There was a problem hiding this comment.
It will not throw any exception. Field value will be empty.
jmazanec15
approved these changes
Oct 30, 2021
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: Vijayan Balasubramanian <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: Vijayan Balasubramanian <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Model Search API response to Model Index document search response.
Issues Resolved
#160
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.