Remove unnecessary toString conversion of vector field and added some minor optimization in KNNCodec #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
navneet1v
added
Enhancements
… minor optimization in KNNCodec Signed-off-by: Navneet Verma <[email protected]>
src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldMapperUtil.java
Show resolved
Hide resolved
martin-gaievski
approved these changes
Apr 12, 2024
junqiu-lei
approved these changes
Apr 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
… minor optimization in KNNCodec (#1613) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit b48ab30)
navneet1v
added a commit
that referenced
this pull request
Apr 12, 2024
… minor optimization in KNNCodec (#1613) (#1615) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit b48ab30) Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary toString conversion of vector field and added some minor optimization in KNNCodec
Issues Resolved
#1598
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.