Fixing KNNCodecServiceTests as reported in the gh issue:[#1593] #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
navneet1v
force-pushed
the
codec-test-fix
branch
from
00eb4f6 to
d0b0510
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
============================================
- Coverage 84.92% 84.87% -0.06%
+ Complexity 1375 1374 -1
============================================
Files 172 172
Lines 5605 5605
Branches 553 553
============================================
- Hits 4760 4757 -3
- Misses 612 614 +2
- Partials 233 234 +1 ☔ View full report in Codecov by Sentry. |
naveentatikonda
previously approved these changes
Apr 9, 2024
junqiu-lei
previously approved these changes
Apr 9, 2024
jmazanec15
reviewed
Apr 9, 2024
…roject#1593] Signed-off-by: Navneet Verma <[email protected]>
navneet1v
dismissed stale reviews from junqiu-lei, naveentatikonda, and vamshin
via
5f0ba36
navneet1v
force-pushed
the
codec-test-fix
branch
from
d0b0510 to
5f0ba36
Compare
navneet1v
requested review from
jmazanec15,
junqiu-lei,
naveentatikonda and
vamshin
jmazanec15
approved these changes
Apr 9, 2024
martin-gaievski
approved these changes
Apr 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 5de10fc)
ryanbogan
pushed a commit
that referenced
this pull request
Apr 29, 2024
… (#1663) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 5de10fc) Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing KNNCodecServiceTests as reported in the gh issue:[#1593]
Currently the issue is only in main branch.
Issues Resolved
#1593
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.