-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add micro-benchmark module in k-NN plugin for benchmark streaming vectors to JNI layer functionality. #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
March 28, 2024 06:09
navneet1v
force-pushed
the
stream-vectors
branch
from
March 28, 2024 06:10
e43f598
to
0f04e26
Compare
navneet1v
force-pushed
the
stream-vectors
branch
from
March 28, 2024 06:23
0f04e26
to
56d7f29
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
============================================
- Coverage 84.96% 84.87% -0.10%
+ Complexity 1366 1365 -1
============================================
Files 172 172
Lines 5566 5572 +6
Branches 546 546
============================================
Hits 4729 4729
- Misses 605 610 +5
- Partials 232 233 +1 ☔ View full report in Codecov by Sentry. |
jmazanec15
reviewed
Mar 28, 2024
micro-benchmarks/src/main/java/org/opensearch/knn/TransferVectorsBenchmarks.java
Outdated
Show resolved
Hide resolved
navneet1v
force-pushed
the
stream-vectors
branch
from
March 28, 2024 17:19
56d7f29
to
9e6ea1a
Compare
…ctors to JNI layer functionality. Signed-off-by: Navneet Verma <[email protected]>
navneet1v
force-pushed
the
stream-vectors
branch
from
March 28, 2024 17:36
9e6ea1a
to
622ea16
Compare
jmazanec15
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
ryanbogan
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
…ctors to JNI layer functionality. (#1583) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit cc91c7c)
navneet1v
added a commit
that referenced
this pull request
Apr 3, 2024
…ctors to JNI layer functionality. (#1583) (#1584) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit cc91c7c) Co-authored-by: Navneet Verma <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add micro-benchmark module in k-NN plugin for benchmark streaming vectors to JNI layer functionality.
This is first of many PR that will be raised for Issue: #1506.
The benchmark results that will be used in #1506 will come from this change. Hence adding it upfront.
Along with this change I am adding a new interface in JNILayer: transferVectorsV2, which is actually getting benchmarked. This interface is experimental and will changed once I start the feature development. Right now I have marked the interface as experimental.
What is micro-benchmarks? and how it is useful?
Micro-benchmark is a new module which is getting added in k-NN plugin that will host some client code to run the performance benchmarks. This module will help us do the benchmarking of a specific internal piece of code/functions/feature of k-NN plugin without setting up the whole cluster. Internally the module uses JMH as the benchmarking platform.
Results
./gradlew -p micro-benchmarks run --args ' -gc true ' -Djvm.heap.size=16g
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.