Fix FieldInfo Parameters Mismatch #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
fix_lucene_FieldInfo
branch
from
7ab0156 to
be8a1ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
============================================
- Coverage 85.02% 84.96% -0.06%
+ Complexity 1278 1277 -1
============================================
Files 167 167
Lines 5207 5207
Branches 493 493
============================================
- Hits 4427 4424 -3
- Misses 573 575 +2
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
|
We already have an issue created for Failing Rolling Upgrade Tests |
|
what is the lucene version with that change that has been adopted by core? |
From 9.9.2 to 9.10.0 https://github.com/opensearch-project/OpenSearch/pull/12392/files |
|
do we need to do routine for knn codec version bump? |
We can do it when the build fails |
heemin32
approved these changes
Feb 21, 2024
naveentatikonda
merged commit c6ac3db
into
opensearch-project:main
47 of 49 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit c6ac3db)
naveentatikonda
added a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit c6ac3db) Co-authored-by: Naveen Tatikonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the breaking change coming from apache/lucene#12829 which is failing the build due to mismatch in FieldInfo parameters.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.