Pass correct value on IDSelectorBitmap initialization #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
heemin32
added
backport 2.x
v2.12.0
Bug Fixes
Signed-off-by: Heemin Kim <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
=========================================
Coverage 84.90% 84.90%
Complexity 1273 1273
=========================================
Files 167 167
Lines 5186 5186
Branches 491 491
=========================================
Hits 4403 4403
Misses 574 574
Partials 209 209 ☔ View full report in Codecov by Sentry. |
jmazanec15
approved these changes
Feb 2, 2024
junqiu-lei
approved these changes
Feb 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 4c7a055)
heemin32
added a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 4c7a055) Co-authored-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In IDSelectorBitmap initialization, we pass size of filtered id array which is not correct. It should be size of bitmap.
Issues Resolved
#1435
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.