Handle multi-vector in exact search scenario #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heemin Kim <[email protected]>
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
============================================
+ Coverage 84.87% 84.99% +0.12%
- Complexity 1262 1274 +12
============================================
Files 165 167 +2
Lines 5143 5179 +36
Branches 480 483 +3
============================================
+ Hits 4365 4402 +37
+ Misses 574 572 -2
- Partials 204 205 +1 ☔ View full report in Codecov by Sentry. |
junqiu-lei
approved these changes
Jan 19, 2024
martin-gaievski
approved these changes
Jan 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 8c98265)
heemin32
added a commit
that referenced
this pull request
Jan 19, 2024
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 8c98265) Co-authored-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code is already approved but missed somehow from the feature branch.
#1378
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.