Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Clear Cache API Test #1336

Conversation

naveentatikonda
Copy link
Member

Description

Fix failing integration test. If there are any system indices in the cluster, the test will fail during validation as they are non-knn indices.

org.opensearch.knn.plugin.action.RestClearCacheHandlerIT > testClearCacheMultipleIndices FAILED
    org.opensearch.client.ResponseException: method [POST], host [https://127.0.0.1:52190/], URI [/_plugins/_knn/clear_cache/_all], status line [HTTP/2.0 500 Internal Server Error]
    {"error":{"root_cause":[{"type":"k_n_n_invalid_indices_exception","reason":"ClearCache request rejected. One or more indices have 'index.knn' set to false."}],"type":"k_n_n_invalid_indices_exception","reason":"ClearCache request rejected. One or more indices have 'index.knn' set to false."},"status":500}

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <[email protected]>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e2f899) 85.13% compared to head (95e8603) 85.13%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1336   +/-   ##
=========================================
  Coverage     85.13%   85.13%           
  Complexity     1210     1210           
=========================================
  Files           160      160           
  Lines          4931     4931           
  Branches        449      449           
=========================================
  Hits           4198     4198           
  Misses          537      537           
  Partials        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda naveentatikonda merged commit aa30992 into opensearch-project:main Dec 7, 2023
62 checks passed
@naveentatikonda naveentatikonda deleted the fix_failing_clear_cache_test branch December 7, 2023 19:48
naveentatikonda added a commit that referenced this pull request Apr 13, 2024
naveentatikonda added a commit that referenced this pull request Apr 13, 2024
* [k-NN] Add Clear Cache API (#740)

* Add Clear Cache API

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add Unit and Integration tests

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add BWC Tests

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add CHANGELOG

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit 12f4a51)
Signed-off-by: Naveen Tatikonda <[email protected]>

* Fix Failing Clear Cache API Test (#1336)

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>
Co-authored-by: Naveen Tatikonda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integ-test-failure Integration test failures skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants