Improved the logic to switch to exact search for restrictive filters search. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
navneet1v
added
backport 2.x
Features
…search. This change includes: * adding 2 extra advanced K-NN settings on when to do exact search for users to tune. Signed-off-by: Navneet Verma <[email protected]>
vibrantvarun
approved these changes
Aug 23, 2023
martin-gaievski
approved these changes
Aug 23, 2023
junqiu-lei
approved these changes
Aug 23, 2023
naveentatikonda
approved these changes
Aug 23, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
…search. (#1059) This change includes: * adding 2 extra advanced K-NN settings on when to do exact search for users to tune. Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4edc1bf)
navneet1v
added a commit
that referenced
this pull request
Aug 23, 2023
…search. (#1059) (#1060) This change includes: * adding 2 extra advanced K-NN settings on when to do exact search for users to tune. Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 4edc1bf) Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the logic to switch to exact search for restrictive filters search.
This change includes:
This change doesn't include:
For understanding the details of the change please refer this issue: #1049
The integration tests are failing as the new backward incompatible changes are not available in snapshot. opensearch-project/OpenSearch#9081 (comment)
Issues Resolved
#1049
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.