Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compilation errors from mediatype refactoring changes #1029

Conversation

martin-gaievski
Copy link
Member

Description

Fixed compilation errors after changes in core (opensearch-project/OpenSearch#9078, opensearch-project/OpenSearch#9050 and opensearch-project/OpenSearch#9054)

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1029 (f53b1c9) into 2.x (85c5a3a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1029      +/-   ##
============================================
+ Coverage     85.07%   85.13%   +0.06%     
- Complexity     1145     1148       +3     
============================================
  Files           154      154              
  Lines          4702     4702              
  Branches        428      428              
============================================
+ Hits           4000     4003       +3     
+ Misses          509      506       -3     
  Partials        193      193              
Files Changed Coverage Δ
...ain/java/org/opensearch/knn/index/KNNSettings.java 84.37% <ø> (ø)
.../opensearch/knn/index/KNNVectorIndexFieldData.java 100.00% <ø> (ø)
...index/codec/KNN80Codec/KNN80DocValuesConsumer.java 88.69% <100.00%> (ø)

... and 3 files with indirect coverage changes

@martin-gaievski martin-gaievski merged commit decc8e2 into opensearch-project:2.x Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants