-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin migration] Update upstream #1
Conversation
Updated build file to use openserach-7.10.3-SNAPSHOT as upstream.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good to me.
Few minor comments.
build.gradle
Outdated
es_version = System.getProperty("es.version", "7.10.3") | ||
es_group = "org.opensearch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, can we rename es
to opensearch
es_version = System.getProperty("es.version", "7.10.3") | |
es_group = "org.opensearch" | |
opensearch_version = System.getProperty("es.version", "7.10.3") | |
opensearch_group = "org.opensearch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
build.gradle
Outdated
//apply plugin: 'elasticsearch.esplugin' | ||
//apply plugin: 'elasticsearch.rest-test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an unintended comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks.
Will rename variables in next PR. Would like to make sure build works with OpenSearch as upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will file paths be updated in a followup PR?
Also, does Cmake file need to be updated in this PR? https://github.com/opensearch-project/k-NN/blob/main/jni/CMakeLists.txt
I believe that library or path should nat have impact since we are just updating only the upstream. if not, can you let me know where are we using absolute path instead of relative? |
35ac095
to
2809c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Updated build file to use openserach-7.10.3-SNAPSHOT as upstream.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.