Add bwc test

Adding BWC test. Currently it fails for 1.1 to 1.2+. Will fix in subsequent commit. Signed-off-by: John Mazanec <[email protected]>
opensearch-project · Apr 5, 2022 · 8ffcd3c · 8ffcd3c
1 parent 77ffa9b
commit 8ffcd3c
Showing 1 changed file with 40 additions and 0 deletions.
diff --git a/src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java b/src/test/java/org/opensearch/knn/bwc/KNNBackwardsCompatibilityIT.java
@@ -11,6 +11,8 @@
 import java.util.Set;
 import java.util.stream.Collectors;
 import org.apache.http.util.EntityUtils;
+import org.opensearch.common.Strings;
+import org.opensearch.common.xcontent.XContentFactory;
 import org.opensearch.knn.KNNResult;
 import org.opensearch.knn.TestUtils;
 import org.opensearch.knn.index.KNNQueryBuilder;
@@ -22,13 +24,18 @@
 import org.opensearch.knn.index.SpaceType;
 import org.opensearch.test.rest.OpenSearchRestTestCase;
 import static org.opensearch.knn.TestUtils.*;
+import static org.opensearch.knn.common.KNNConstants.KNN_METHOD;
+import static org.opensearch.knn.common.KNNConstants.METHOD_HNSW;
+import static org.opensearch.knn.common.KNNConstants.NAME;
+import static org.opensearch.knn.common.KNNConstants.PARAMETERS;
 import static org.opensearch.knn.index.KNNSettings.KNN_ALGO_PARAM_INDEX_THREAD_QTY;
 import static org.opensearch.knn.index.KNNSettings.KNN_MEMORY_CIRCUIT_BREAKER_ENABLED;
 
 public class KNNBackwardsCompatibilityIT extends KNNRestTestCase {
     private static final String CLUSTER_NAME = System.getProperty(TEST_CLUSTER_NAME);
     private final String testIndexName = KNN_BWC_PREFIX + "test-index";
     private final String testIndex_Recall = KNN_BWC_PREFIX + "test-index-recall";
+    private final String testIndex_NullParams = KNN_BWC_PREFIX + "test-index-null-params";
     private final String testFieldName = "test-field";
     private final String testField_Recall = "test-field-recall";
     private final String testIndex_Recall_Old = KNN_BWC_PREFIX + "test-index-recall-value-old";
@@ -234,6 +241,39 @@ public void testBackwardsCompatibility() throws Exception {
         }
     }
 
+    public void testNullParametersOnUpgrade() throws Exception {
+        // Confirm cluster is green before starting
+        Request waitForGreen = new Request("GET", "/_cluster/health");
+        waitForGreen.addParameter("wait_for_nodes", "3");
+        waitForGreen.addParameter("wait_for_status", "green");
+        client().performRequest(waitForGreen);
+
+        switch (getClusterType()) {
+            case OLD:
+                String mapping = Strings.toString(
+                    XContentFactory.jsonBuilder()
+                        .startObject()
+                        .startObject("properties")
+                        .startObject(testFieldName)
+                        .field("type", "knn_vector")
+                        .field("dimension", String.valueOf(dimensions))
+                        .startObject(KNN_METHOD)
+                        .field(NAME, METHOD_HNSW)
+                        .field(PARAMETERS, (String) null)
+                        .endObject()
+                        .endObject()
+                        .endObject()
+                        .endObject()
+                );
+
+                createKnnIndex(testIndex_NullParams, getKNNDefaultIndexSettings(), mapping);
+                break;
+            case UPGRADED:
+                deleteKNNIndex(testIndex_NullParams);
+                break;
+        }
+    }
+
     private String getUri(ClusterType clusterType) {
         switch (clusterType) {
             case OLD: