Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @prudhvigodithi as a Maintainer #625

Merged
merged 1 commit into from
May 2, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 2, 2024

Description

@prudhvigodithi currently has the 4th most contributions on the repo with 15 PRs merged to date.

Notable contributions include:

Nomination process has been concluded and approved by the current maintainers, nominee has accepted.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@dbwiddis dbwiddis merged commit 73cf6d8 into opensearch-project:main May 2, 2024
13 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-2.x
# Create a new branch
git switch --create backport/backport-625-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73cf6d8228e8a60293d9a649ad8d462814fd1724
# Push it to GitHub
git push --set-upstream origin backport/backport-625-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-625-to-2.x.

@prudhvigodithi
Copy link
Member

Thanks @cwperks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants