Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless plugin remove apply false #590

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Feb 22, 2024

Description

Spotless plugin remove apply false. With false Gradle will not automatically download and configure the plugin and its dependencies from remote repositories during the build process.
Using apply false in an internet-restricted environment can potentially lead to issues if the plugin's dependencies are not already available locally.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <[email protected]>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f453c89) 29.17% compared to head (51e4555) 29.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #590   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1186     1186           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          819      819           
  Partials         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi prudhvigodithi merged commit 5226c31 into opensearch-project:main Feb 22, 2024
19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 5226c31)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 5226c31)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks pushed a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 5226c31)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 5226c31)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants