-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copies zips from local staging to m2 #582
Conversation
Signed-off-by: owaiskazi19 <[email protected]>
cp -r ./build/local-staging-repo/org/opensearch/. $OUTPUT/maven/org/opensearch | ||
cp -r ./build/local-staging-repo/org/opensearch/plugin/opensearch-job-scheduler ~/.m2/repository/org/opensearch/plugin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owaiskazi19 please add a comment linking the skills repo issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: owaiskazi19 <[email protected]>
I see this works, skills does not complain job-scheduler (as seen in past) as it copied to local maven.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=========================================
Coverage 29.17% 29.17%
Complexity 98 98
=========================================
Files 22 22
Lines 1186 1186
Branches 109 109
=========================================
Hits 346 346
Misses 819 819
Partials 21 21 ☔ View full report in Codecov by Sentry. |
@peterzhuamazon do you see any issues with windows? |
Instead of copying, I have a PR open which publishes the zips to maven local in gradle way #584. |
@prudhvigodithi can we close this then? |
Yes @owaiskazi19 closing this in favor of #584. Thanks |
Description
Coming from #581 (comment)
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.