Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copies zips from local staging to m2 #582

Closed
wants to merge 2 commits into from

Conversation

owaiskazi19
Copy link
Member

Description

Coming from #581 (comment)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cp -r ./build/local-staging-repo/org/opensearch/. $OUTPUT/maven/org/opensearch
cp -r ./build/local-staging-repo/org/opensearch/plugin/opensearch-job-scheduler ~/.m2/repository/org/opensearch/plugin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owaiskazi19 please add a comment linking the skills repo issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: owaiskazi19 <[email protected]>
@prudhvigodithi
Copy link
Member

I see this works, skills does not complain job-scheduler (as seen in past) as it copied to local maven.

* What went wrong:
A problem occurred evaluating root project 'opensearch-skills'.
> Could not resolve all files for configuration ':zipArchive'.
   > Could not find org.opensearch.plugin:opensearch-ml-plugin:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-ml-plugin/2.12.0.0/opensearch-ml-plugin-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/opensearch-ml-plugin/2.12.0.0/opensearch-ml-plugin-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/opensearch-ml-plugin/2.12.0.0/opensearch-ml-plugin-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.12.0.0/opensearch-ml-plugin-2.12.0.0.pom
     Required by:
         project :
   > Could not find org.opensearch.plugin:opensearch-anomaly-detection:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-anomaly-detection/2.12.0.0/opensearch-anomaly-detection-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/opensearch-anomaly-detection/2.12.0.0/opensearch-anomaly-detection-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/opensearch-anomaly-detection/2.12.0.0/opensearch-anomaly-detection-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-anomaly-detection/2.12.0.0/opensearch-anomaly-detection-2.12.0.0.pom
     Required by:
         project :
   > Could not find org.opensearch.plugin:opensearch-sql-plugin:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-sql-plugin/2.12.0.0/opensearch-sql-plugin-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/opensearch-sql-plugin/2.12.0.0/opensearch-sql-plugin-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/opensearch-sql-plugin/2.12.0.0/opensearch-sql-plugin-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.12.0.0/opensearch-sql-plugin-2.12.0.0.pom
     Required by:
         project :
   > Could not find org.opensearch.plugin:opensearch-knn:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/opensearch-knn/2.12.0.0/opensearch-knn-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/opensearch-knn/2.12.0.0/opensearch-knn-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/opensearch-knn/2.12.0.0/opensearch-knn-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-knn/2.12.0.0/opensearch-knn-2.12.0.0.pom
     Required by:
         project :
   > Could not find org.opensearch.plugin:neural-search:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/neural-search/2.12.0.0/neural-search-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/neural-search/2.12.0.0/neural-search-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/neural-search/2.12.0.0/neural-search-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/neural-search/2.12.0.0/neural-search-2.12.0.0.pom
     Required by:
         project :
   > Could not find org.opensearch.plugin:alerting:2.12.0.0.
     Searched in the following locations:
       - file:/home/ci-runner/.m2/repository/org/opensearch/plugin/alerting/2.12.0.0/alerting-2.12.0.0.pom
       - https://repo.maven.apache.org/maven2/org/opensearch/plugin/alerting/2.12.0.0/alerting-2.12.0.0.pom
       - https://plugins.gradle.org/m2/org/opensearch/plugin/alerting/2.12.0.0/alerting-2.12.0.0.pom
       - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/alerting/2.12.0.0/alerting-2.12.0.0.pom
     Required by:
         project :

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c390d00) 29.17% compared to head (125523b) 29.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #582   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1186     1186           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          819      819           
  Partials         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi prudhvigodithi self-requested a review February 9, 2024 03:42
@prudhvigodithi
Copy link
Member

@peterzhuamazon do you see any issues with windows?

@prudhvigodithi
Copy link
Member

Instead of copying, I have a PR open which publishes the zips to maven local in gradle way #584.
@peterzhuamazon @bbarani

@owaiskazi19
Copy link
Member Author

@prudhvigodithi can we close this then?

@prudhvigodithi
Copy link
Member

Yes @owaiskazi19 closing this in favor of #584. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants