Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting JobSweeper search preference against primary shard #483

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Setting JobSweeper search preference against primary shard #483

merged 5 commits into from
Sep 6, 2023

Conversation

joshpalis
Copy link
Member

Description

Sets the search preference of the JobSweeper against primary shards

Issues Resolved

#471

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #483 (67f3b21) into main (886fa11) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main     #483   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1186     1186           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          819      819           
  Partials         21       21           
Files Changed Coverage Δ
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.74% <0.00%> (ø)

vibrantvarun
vibrantvarun previously approved these changes Sep 5, 2023
cwperks
cwperks previously approved these changes Sep 5, 2023
@joshpalis joshpalis dismissed stale reviews from vibrantvarun and cwperks via 01e8dec September 5, 2023 22:49
@joshpalis joshpalis merged commit c1e2569 into opensearch-project:main Sep 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
* Setting sweepShard search request against primary shard

Signed-off-by: Joshua Palis <[email protected]>

* testing primary first

Signed-off-by: Joshua Palis <[email protected]>

* reverting back to primary

Signed-off-by: Joshua Palis <[email protected]>

* setting fail fast to false

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit c1e2569)
cwperks pushed a commit that referenced this pull request Sep 6, 2023
* Setting sweepShard search request against primary shard

Signed-off-by: Joshua Palis <[email protected]>

* testing primary first

Signed-off-by: Joshua Palis <[email protected]>

* reverting back to primary

Signed-off-by: Joshua Palis <[email protected]>

* setting fail fast to false

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit c1e2569)

Co-authored-by: Joshua Palis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants