Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to changes in ActionListener and ActionFuture from #9082 #464

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 11, 2023

Description

Reacts to changes in ActionListener and ActionResponse introduced in opensearch-project/OpenSearch#9082

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #464 (5bf1867) into main (50d1db3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #464   +/-   ##
=========================================
  Coverage     29.19%   29.19%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1185     1185           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          818      818           
  Partials         21       21           
Files Changed Coverage Δ
...scheduler/rest/action/RestGetJobDetailsAction.java 42.59% <ø> (ø)
...ch/jobscheduler/rest/action/RestGetLockAction.java 34.69% <ø> (ø)
...obscheduler/rest/action/RestReleaseLockAction.java 11.11% <ø> (ø)
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.74% <ø> (ø)
...duler/transport/response/JobParameterResponse.java 0.00% <ø> (ø)
...cheduler/transport/response/JobRunnerResponse.java 0.00% <ø> (ø)
...ensearch/jobscheduler/utils/JobDetailsService.java 2.57% <ø> (ø)

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwperks

@joshpalis joshpalis mentioned this pull request Aug 11, 2023
5 tasks
@kaituo kaituo merged commit 6abaa3c into opensearch-project:main Aug 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 14, 2023
* React to changes in ActionListener and ActionFuture from #9082

Signed-off-by: Craig Perkins <[email protected]>

* Checkin all files

Signed-off-by: Craig Perkins <[email protected]>

* LockServiceIT

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 6abaa3c)
kaituo pushed a commit that referenced this pull request Aug 14, 2023
…#467)

* React to changes in ActionListener and ActionFuture from #9082

Signed-off-by: Craig Perkins <[email protected]>

* Checkin all files

Signed-off-by: Craig Perkins <[email protected]>

* LockServiceIT

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 6abaa3c)

Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants