-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to changes in ActionListener and ActionFuture from #9082 #464
Merged
kaituo
merged 3 commits into
opensearch-project:main
from
cwperks:action-listener-update
Aug 11, 2023
Merged
React to changes in ActionListener and ActionFuture from #9082 #464
kaituo
merged 3 commits into
opensearch-project:main
from
cwperks:action-listener-update
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo and
vibrantvarun
as code owners
August 11, 2023 04:11
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
=========================================
Coverage 29.19% 29.19%
Complexity 98 98
=========================================
Files 22 22
Lines 1185 1185
Branches 109 109
=========================================
Hits 346 346
Misses 818 818
Partials 21 21
|
joshpalis
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cwperks
kaituo
approved these changes
Aug 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* React to changes in ActionListener and ActionFuture from #9082 Signed-off-by: Craig Perkins <[email protected]> * Checkin all files Signed-off-by: Craig Perkins <[email protected]> * LockServiceIT Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 6abaa3c)
kaituo
pushed a commit
that referenced
this pull request
Aug 14, 2023
…#467) * React to changes in ActionListener and ActionFuture from #9082 Signed-off-by: Craig Perkins <[email protected]> * Checkin all files Signed-off-by: Craig Perkins <[email protected]> * LockServiceIT Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 6abaa3c) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reacts to changes in ActionListener and ActionResponse introduced in opensearch-project/OpenSearch#9082
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.