Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages according to a change in OpenSearch core #422

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Update packages according to a change in OpenSearch core #422

merged 1 commit into from
Jul 14, 2023

Conversation

heemin32
Copy link
Contributor

Description

Update packages according to a change in OpenSearch core

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbwiddis
dbwiddis previously approved these changes Jul 13, 2023
View reviewed changes
@heemin32
Copy link
Contributor Author

Local build succeeded. BWC test is failing.

@heemin32 heemin32 force-pushed the migration branch 2 times, most recently from 88139b1 to 6293b3a Compare July 13, 2023 23:31
@heemin32 heemin32 requested a review from dbwiddis July 13, 2023 23:53
@vibrantvarun
Copy link
Member

Hey @heemin32 the PR checks are failing. Check Bwc Tests

@heemin32
Copy link
Contributor Author

heemin32 commented Jul 14, 2023 •
edited
Loading

Hey @heemin32 the PR checks are failing. Check Bwc Tests

The failure is not from my changes. It could be because the changes in the OpenSearch core is not reached to docker repo where we pull and launch cluster.

Compiling of job-scheduler is already broken without this PR and all the dependency components also fail until job-scheduler compiling is fixed.

@vibrantvarun
Copy link
Member

So is it like merging this PR with failing checks will fix the dependency issue?
cc: @heemin32

@heemin32
Copy link
Contributor Author

heemin32 commented Jul 14, 2023 •
edited
Loading

So is it like merging this PR with failing checks will fix the dependency issue? cc: @heemin32

Without this change, job-scheduler build fails. This PR will make job-scheduler build succeed. The failure in BWC test might be fixed once the OpenSearch core artifact is released in Docker repo I assume. Otherwise need to create a separate issue to fix the BWC test failure.

@vibrantvarun vibrantvarun merged commit 35333ed into opensearch-project:main Jul 14, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2023
@heemin32 @github-actions
Update packages according to a change in OpenSearch core (#422)
7c58a58 
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit 35333ed)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 24, 2023
Merged
vibrantvarun pushed a commit that referenced this pull request Jul 24, 2023
@opensearch-trigger-bot @heemin32
Update packages according to a change in OpenSearch core (#422) (#431)
6acb389 
Signed-off-by: Heemin Kim <[email protected]>
(cherry picked from commit 35333ed)

Co-authored-by: Heemin Kim <[email protected]>
@heemin32 heemin32 deleted the migration branch July 28, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibrantvarun vibrantvarun vibrantvarun approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heemin32 @vibrantvarun @dbwiddis @owaiskazi19