Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MacOS CI Workflow #412

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

owaiskazi19
Copy link
Member

Description

Added MacOS CI Workflow for JS

Issues Resolved

Fixes #76

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: owaiskazi19 <[email protected]>
@joshpalis
Copy link
Member

Execution failed for task ':opensearch-job-scheduler-sample-extension:jobSchedulerBwcCluster#oldVersionClusterTask1'.
> Could not resolve all files for configuration ':opensearch-job-scheduler-sample-extension:opensearch_distro_extracted_testclusters-opensearch-job-scheduler-sample-extension-jobSchedulerBwcCluster1-0-2.9.0-'.
   > Could not resolve opensearch-distribution:opensearch:2.9.0.
     Required by:
         project :opensearch-job-scheduler-sample-extension
      > Could not resolve opensearch-distribution:opensearch:2.9.0.
         > Could not get resource 'https://artifacts.opensearch.org/releases/core/opensearch/2.9.0/opensearch-min-2.9.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/releases/core/opensearch/2.9.0/opensearch-min-2.9.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden
      > Could not resolve opensearch-distribution:opensearch:2.9.0.
         > Could not get resource 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.9.0/opensearch-min-2.9.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.9.0/opensearch-min-2.9.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden

@@ -30,7 +30,7 @@ jobs:

- name: Build and Test
run: |
./gradlew build
./gradlew build -x bwcTestSuite
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a different workflow bwcTest already. Excluding it here.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #412 (d9917c9) into main (0132436) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #412   +/-   ##
=========================================
  Coverage     28.77%   28.77%           
  Complexity       97       97           
=========================================
  Files            22       22           
  Lines          1178     1178           
  Branches        109      109           
=========================================
  Hits            339      339           
  Misses          818      818           
  Partials         21       21           

@joshpalis
Copy link
Member

@owaiskazi19 should we backport to 2.x as well?

@joshpalis joshpalis merged commit 88479dd into opensearch-project:main Jul 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 7, 2023
* Added MacOS CI Workflow

Signed-off-by: owaiskazi19 <[email protected]>

* Used snapshot url for macos

Signed-off-by: owaiskazi19 <[email protected]>

* Added case for ubuntu and windows

Signed-off-by: owaiskazi19 <[email protected]>

* Exclude bwcTest for macOS

Signed-off-by: owaiskazi19 <[email protected]>

* Exclude bwcTestSuite for all OS

Signed-off-by: owaiskazi19 <[email protected]>

---------

Signed-off-by: owaiskazi19 <[email protected]>
(cherry picked from commit 88479dd)
joshpalis pushed a commit that referenced this pull request Jul 7, 2023
* Added MacOS CI Workflow

Signed-off-by: owaiskazi19 <[email protected]>

* Used snapshot url for macos

Signed-off-by: owaiskazi19 <[email protected]>

* Added case for ubuntu and windows

Signed-off-by: owaiskazi19 <[email protected]>

* Exclude bwcTest for macOS

Signed-off-by: owaiskazi19 <[email protected]>

* Exclude bwcTestSuite for all OS

Signed-off-by: owaiskazi19 <[email protected]>

---------

Signed-off-by: owaiskazi19 <[email protected]>
(cherry picked from commit 88479dd)
Signed-off-by: Joshua Palis <[email protected]>
vibrantvarun pushed a commit that referenced this pull request Jul 7, 2023
* Added MacOS CI Workflow



* Used snapshot url for macos



* Added case for ubuntu and windows



* Exclude bwcTest for macOS



* Exclude bwcTestSuite for all OS



---------


(cherry picked from commit 88479dd)

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MacOS Support
3 participants