Artifacts path update at right location #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
joshpalis,
saratvemulapalli,
dbwiddis and
kaituo
as code owners
cwperks
reviewed
May 3, 2023
There was a problem hiding this comment.
Great job figuring this out @vibrantvarun! I have checked out this branch and verified the changes locally.
build.gradle
Outdated
| } | ||
| repositories { | ||
| maven { | ||
| name = "Snapshots" // optional target repository name | ||
| url = "https://aws.oss.sonatype.org/content/repositories/snapshots" | ||
| url = "https://aws.oss.sonatype.org/content/repositories/snapshots/snapshots" |
There was a problem hiding this comment.
Reverted it. Changed by mistake. Thanks for calling it out
| developer.appendNode('url', 'https://github.com/opensearch-project/job-scheduler') | ||
| } | ||
| } | ||
| // all { |
There was a problem hiding this comment.
Can we remove the commented out lines?
There was a problem hiding this comment.
I'm still seeing commented out lines in the PR.
There was a problem hiding this comment.
+1 lm still seeing commented code.
build.gradle
Outdated
| @@ -136,11 +136,31 @@ publishing { | |||
| groupId = "org.opensearch.plugin" | |||
| } | |||
| } | |||
| mavenJava(MavenPublication){ publication -> | |||
There was a problem hiding this comment.
nit: with the other publication called pluginZip, do you think we should call this pluginJar?
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
There was a problem hiding this comment.
The changes look good to me. Thanks @vibrantvarun .
Could you take a look at the CI failures?
@prudhvigodithi @gaiksaya how do we fix this for 2.7 published release after this change is merged?
| developer.appendNode('url', 'https://github.com/opensearch-project/job-scheduler') | ||
| } | ||
| } | ||
| // all { |
There was a problem hiding this comment.
+1 lm still seeing commented code.
|
Hi @vibrantvarun, Can you check if it is publishing as expected on maven local too? Details
Which are then downloaded from S3 and published using maven cli. Workflow: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch-maven-release/publish-to-maven.jenkinsfile#L39-L44 @saratvemulapalli @prudhvigodithi I believe we might need to document the process step by step of manual checking out the job scheduler repo at tag 2.7.0.0, cherry-pick this commit, get maven credentials and only run publish task for this URL: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/opensearch-job-scheduler/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the artifact publishing issue with job scheduler. I have added a new publication called mavenJava in the build .gradle which does packaging in Jar to the right publishing path.
Steps I followed to test:
Please find the test output below.
Issues Resolved
#374
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.