Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupId to pom section of build.gradle #363

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 12, 2023

Description

This should be the last PR to fix the publishNebulaPublicationToSnapshotsRepository gradle task. There was a pom section in the gradle build missing groupId = "org.opensearch.plugin"

When I run this locally it gets past the groupId error and fails on sonatype publication since my local machine isn't configured to publish artifacts.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #363 (90d5471) into main (3009325) will decrease coverage by 0.09%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #363      +/-   ##
============================================
- Coverage     28.77%   28.69%   -0.09%     
+ Complexity       97       96       -1     
============================================
  Files            22       22              
  Lines          1178     1178              
  Branches        109      109              
============================================
- Hits            339      338       -1     
  Misses          818      818              
- Partials         21       22       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshpalis joshpalis merged commit 60c61a6 into opensearch-project:main Apr 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 60c61a6)
joshpalis pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 60c61a6)

Co-authored-by: Craig Perkins <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
…ct#364)

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 60c61a6)

Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants