Decoupling Snapshots for v2.6.0 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vibrantvarun Can you post the output of the tests in this PR? Details about testing is in the issue. |
6 tasks
|
cc: @gaiksaya @joshpalis Testing Result |
gaiksaya
requested changes
Feb 21, 2023
.github/workflows/maven-publish.yml
Outdated
| export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text) | ||
| echo "::add-mask::$SONATYPE_USERNAME" | ||
| echo "::add-mask::$SONATYPE_PASSWORD" | ||
| ./gradlew publishNebulaPublicationToSnapshotsRepository |
There was a problem hiding this comment.
I am seeing multipple locations of JS in our snapshots:
- https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-job-scheduler-spi/
- https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-job-scheduler/
- https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-job-scheduler/
Can you confirm with the team which are the right ones here and accordingly add those tasks?
Adding @prudhvigodithi here since we had this conversation before
|
Yes the location for job-scheduler for both jar's and zip's look right. The But the fix to remove pushing zips to The reason its working even though zips are part of @vibrantvarun can you please create an issue to remove publishing zips to Thank you |
vibrantvarun
force-pushed
the
DecouplingSnapshots
branch
from
f880800 to
ebd4e81
Compare
|
Apart from above mentioned issues (which can be addressed later) the job-sceduler spis are missing from above output. |
In that case I believe the task that needs to be called is right as mentioned in attached issue. @vibrantvarun please check the issue for more details and try that. |
|
Tried with 2.x branch: |
|
Hey @gaiksaya Can you help me with figuring out what else is required? |
|
I think I figured out for issue with JS. |
Please fix the tasks. Also spi build.gradle needs to have snapshots repository. Posted the tasks above. |
|
cc: @gaiksaya |
joshpalis
previously approved these changes
Feb 22, 2023
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
force-pushed
the
DecouplingSnapshots
branch
from
e808e3a to
743384b
Compare
|
Tested successfully for SPI and plugin cc: @gaiksaya @joshpalis |
joshpalis
approved these changes
Feb 22, 2023
gaiksaya
approved these changes
Feb 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 66d694b)
joshpalis
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 66d694b) Co-authored-by: Varun Jain <[email protected]>
wuychn
pushed a commit
to ochprince/job-scheduler
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 66d694b) Co-authored-by: Varun Jain <[email protected]>
prudhvigodithi
pushed a commit
to prudhvigodithi/job-scheduler
that referenced
this pull request
May 9, 2023
Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit 66d694b) Co-authored-by: Varun Jain <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding maven-publish.yml for decoupling snapshots.
Issues Resolved
#319
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.