Communication Mechanism Work Item 6 Release lock api #312

vibrantvarun · 2023-02-10T18:36:14Z

Description

Release Lock API

Issues Resolved

opensearch-project/opensearch-sdk-java#370

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <[email protected]>

codecov-commenter · 2023-02-13T20:19:59Z

Codecov Report

Merging #312 (c73b633) into main (23c70b9) will decrease coverage by 0.95%.
The diff coverage is 14.17%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #312      +/-   ##
============================================
- Coverage     31.17%   30.23%   -0.95%     
- Complexity       66       97      +31     
============================================
  Files            12       22      +10     
  Lines           773     1128     +355     
  Branches         80      107      +27     
============================================
+ Hits            241      341     +100     
- Misses          513      766     +253     
- Partials         19       21       +2

Impacted Files	Coverage Δ
...rg/opensearch/jobscheduler/JobSchedulerPlugin.java	`31.66% <0.00%> (-1.10%)`	⬇️
...arch/jobscheduler/model/ExtensionJobParameter.java	`0.00% <0.00%> (ø)`
...obscheduler/rest/request/GetJobDetailsRequest.java	`45.16% <ø> (ø)`
...r/transport/request/ExtensionJobActionRequest.java	`0.00% <0.00%> (ø)`
...heduler/transport/request/JobParameterRequest.java	`0.00% <0.00%> (ø)`
...bscheduler/transport/request/JobRunnerRequest.java	`0.00% <0.00%> (ø)`
...transport/response/ExtensionJobActionResponse.java	`0.00% <0.00%> (ø)`
...duler/transport/response/JobParameterResponse.java	`0.00% <0.00%> (ø)`
...cheduler/transport/response/JobRunnerResponse.java	`0.00% <0.00%> (ø)`
...ensearch/jobscheduler/utils/JobDetailsService.java	`2.52% <0.00%> (-1.16%)`	⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshpalis

Doing an initial pass

src/test/java/org/opensearch/jobscheduler/multinode/ReleaseLockActionMultiNodeRestIT.java

src/test/java/org/opensearch/jobscheduler/TestHelpers.java

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun · 2023-02-13T22:07:32Z

Just a premise, This PR has below changes

Reorganizing request files in request package and response files in response package and action files in action package
Release Lock API
Removing _get from RestGetJobDetailsAction api route as the api is already a GET api so it is not needed to be in path

@joshpalis @dbwiddis @saratvemulapalli

dbwiddis

LGTM but a few questions for my own awareness, and strong suggestion of improvement. Feel free to push back if I missed something.

src/main/java/org/opensearch/jobscheduler/rest/action/RestGetJobDetailsAction.java

src/main/java/org/opensearch/jobscheduler/rest/action/RestGetLockAction.java

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

dbwiddis

Approving based on the intent to refactor the temporary fields to completable future .get() in a future PR.

Signed-off-by: Varun Jain <[email protected]>

joshpalis

Second pass. The modifications made to the Rest actions to use completableFuture.get() looks good to me, thanks @dbwiddis for the suggestion. Just had a few minor nits

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

Signed-off-by: Varun Jain <[email protected]>

joshpalis

Thanks for the changes @vibrantvarun

saratvemulapalli · 2023-02-13T23:22:24Z

src/main/java/org/opensearch/jobscheduler/rest/action/RestGetLockAction.java

@@ -70,7 +69,7 @@ public List<Route> routes() {
    }

    @Override
-    protected RestChannelConsumer prepareRequest(RestRequest restRequest, NodeClient client) throws IOException {
+    public RestChannelConsumer prepareRequest(RestRequest restRequest, NodeClient client) throws IOException {


Curious why public? Does it matter?
This interface is anyway called internally by BaseRestHandler[1].

[1] https://github.com/opensearch-project/OpenSearch/blob/0eee9a9403e0338efde497da33fda87c39093b2c/server/src/main/java/org/opensearch/rest/BaseRestHandler.java#L103

yes, because if it is not public then I cannot call it from Test class

you could make it package private and available by tests

saratvemulapalli · 2023-02-13T23:25:55Z

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

+public class RestReleaseLockAction extends BaseRestHandler {
+
+    public static final String RELEASE_LOCK_ACTION = "release_lock_action";
+    public static final String LOCK_ID = "lock_id";


Lets import this from org.opensearch.jobscheduler.spi.LockModel.LOCK_ID.

saratvemulapalli · 2023-02-13T23:32:02Z

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

+            if (e.getCause() instanceof TimeoutException) {
+                logger.info(" Request timed out with an exception ", e);
+            } else {
+                throw e;


Hmm.. do we need the else ? And throw the exception?
The catch all at 87 will anyway take care of it.

@dbwiddis suggested to catch time out exception seperately

Ok if so we need need handle this cleanly, would it drop the rest request ? (I see we are throwing the error, I wonder how this is handled)
Is there a test which tests this case?

No as of now there is no test for this

Lets add one.

OK, I think I may have been confused before and reviewing a PR on opensearch cleared it up. We do need to clean up this exception handling. Take a look at ExternsionsManager and try to follow this pattern:

} catch (CompletionException e) { if (e.getCause() instanceof TimeoutException) { logger.info("No response from extension to request."); } if (e.getCause() instanceof RuntimeException) { throw (RuntimeException) e.getCause(); } else if (e.getCause() instanceof Error) { throw (Error) e.getCause(); } else { throw new RuntimeException(e.getCause()); } }

saratvemulapalli · 2023-02-13T23:33:42Z

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

+                throw e;
+            }
+        } catch (Exception e) {
+            logger.info(" Could not find lock model with lockId due to exception ", e);


Have this log at debug level?[1] Info seems like a lot.

[1] https://www.tutorialspoint.com/log4j/log4j_logging_levels.htm

saratvemulapalli · 2023-02-13T23:38:19Z

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

+            BytesRestResponse bytesRestResponse;
+            try {
+                builder.startObject();
+                builder.field("response", restResponseString);


I would re-name the field to release-lock to be more explicit when the client reads it. response is generic and it brings ambiguity.

Suggested change

builder.field("response", restResponseString);

builder.field("release-lock", restResponseString);

saratvemulapalli

Overall the changes look good to me.
Few minor comments..

Signed-off-by: Varun Jain <[email protected]>

dbwiddis

LGTM but you're duplicating that annotation from elsewhere

dbwiddis · 2023-02-14T16:03:02Z

src/main/java/org/opensearch/jobscheduler/rest/action/VisibleForTesting.java

+ */
+package org.opensearch.jobscheduler.rest.action;
+
+public @interface VisibleForTesting {


Doesn't this already exist?

import com.google.common.annotations.VisibleForTesting; if you have that dependency

import org.opensearch.jobscheduler.utils.VisibleForTesting; otherwise

it does have but it only works when when it is in the same package

Signed-off-by: Varun Jain <[email protected]>

joshpalis

Doing another pass, some minor nits and a request to add guardrails to the releaseLock API

src/main/java/org/opensearch/jobscheduler/rest/action/RestGetLockAction.java

src/main/java/org/opensearch/jobscheduler/rest/action/RestReleaseLockAction.java

Signed-off-by: Varun Jain <[email protected]>

joshpalis

Thanks for the changes @vibrantvarun

…#382) * Communication mechanism for js (#289) * Job Details from Extension for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> * Communication Mechanism for JS Signed-off-by: Varun Jain <[email protected]> Signed-off-by: Varun Jain <[email protected]> * [Extensions] Synchronize opensearch-plugin-job-details with JobDetailsService map (#299) * Added JobDetailsService as an indexOperationListener to synchronize metadata index with internal job details m and indicesToListen set. Signed-off-by: Joshua Palis <[email protected]> * Changes indexToJobDetails to a ConcurrentMap, adds getter method for indexToJobDetails Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, fixing log message Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Added test to updateIndexToJobDetails Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, changing extensionId to extensionUniqueId Signed-off-by: Joshua Palis <[email protected]> * Addressing PR Comments : Updating Job Details index Name and mapping file to opensearch-job-scheduler-job-details Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, enabling extensions to submit more than 1 job details entry to support extensions registering multiple types of jobs, updated all integration, multinode tests now that the rest response value is the document Id Signed-off-by: Joshua Palis <[email protected]> * Renaming TestHelper base URI name Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, made multinode test request strings constant Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: Joshua Palis <[email protected]> * [Extensions] Create a proxy ScheduledJobRunner, ScheduledJobParser to invoke corresponding registered Job Detail actions (#306) * Draft : Added JobParameterRequest to translate ScheduledJobParser parameters nto compatible inputs for the ExtensionActionRequest. Completed initial proxy scheduled job parser implementation. Added ExtensionJobParameter class to deserialize ExtensionActionResponsebyte array into an object of type ScheduledJobParameter Signed-off-by: Joshua Palis <[email protected]> * Added JobRunnerRequest, modified JobExecutionContext to implement writeable, created initial proxy ScheduledJobRunner, fixed failing tests Signed-off-by: Joshua Palis <[email protected]> * Added generic ExtensionJobActionRequest that extends ExtensionActionRequest, modified JobParameter/Runner request to implement writeable, refactored proxy object creation so that the requests are added to the ExtensionJobActionRequest, which in turn upcasts the request into an ExtensionActionRequest Signed-off-by: Joshua Palis <[email protected]> * Added byte array constructors for the JobRunner/Parameter requests, added javadocs Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * Added placeholder string for an eventual access token to be sent to extensions to validate prior to invoking an action Signed-off-by: Joshua Palis <[email protected]> * Added ExtensionJobActionResponse, JobParameterResponse, JobRunnerResponse to facilitate the response of extension actions Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * Added JobRunnerResponse handling Signed-off-by: Joshua Palis <[email protected]> * Separating updateIndexToJobProviders into separate methods Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * SpotlessApply Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Added tests for serialization/deserialization of JobExecutionContext, JobDocVersion, ExtensionJobParameter, ExtensionJobActionRequest, ExtensionJobActionResponse, JobRunner/JobParameter/Request/Response Signed-off-by: Joshua Palis <[email protected]> * Writing ExtensionActionRequest/Response to bytestream output to test deserialization Signed-off-by: Joshua Palis <[email protected]> * Fixing imports Signed-off-by: Joshua Palis <[email protected]> * Changing to extensionActionResponse constructor Signed-off-by: Joshua Palis <[email protected]> * Adding tests for updateIndexToJobProviders Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, added getters for lock duration seconds and jitter values, added javadocs to ScheduleType enum and made this public Signed-off-by: Joshua Palis <[email protected]> * Removing Strings dependency from lock model to fix BWC tests Signed-off-by: Joshua Palis <[email protected]> * Fixes BWC fullRestartClusterTask, rollingUpgradeClusterTask, oldVersionCluster task. mixedClusterTask is still failing Signed-off-by: Joshua Palis <[email protected]> * Modified createProxyScheduledJobRunner to return the document Id of the extension job parameter entry within the registered job index, modifed the ExtensionJobParameter to null check the jitter value and setting this to 0.0 if null Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> * [Extensions] Exposes a GetLock REST API to enable extensions to acquire a lock model for their job execution (#311) * Added RestGetLockAction API, added AcquireLockRequest, enables extensions to retrieve a lock model object to run their Job Signed-off-by: Joshua Palis <[email protected]> * Adding Lock ID field to RestGetLockAction response Signed-off-by: Joshua Palis <[email protected]> * Added multi node integration tests for GetLockApi Signed-off-by: Joshua Palis <[email protected]> * Making lock service in RestGetLockAction private Signed-off-by: Joshua Palis <[email protected]> * Added Rest integration tests for RestGetLockAction Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> * Updating get lock rest path in tests Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> * Communication Mechanism Work Item 6 Release lock api (#312) * Release lock API Signed-off-by: Varun Jain <[email protected]> * Release Lock API Signed-off-by: Varun Jain <[email protected]> * Release Lock API Signed-off-by: Varun Jain <[email protected]> * Release Lock API Signed-off-by: Varun Jain <[email protected]> * Reformatting Signed-off-by: Varun Jain <[email protected]> * Reformatting Signed-off-by: Varun Jain <[email protected]> * Reformatting Signed-off-by: Varun Jain <[email protected]> * Addressing Dan's Comments Signed-off-by: Varun Jain <[email protected]> * Addressing Dan's Comments Signed-off-by: Varun Jain <[email protected]> * Addressing Sarat's Comments Signed-off-by: Varun Jain <[email protected]> * Addressing Sarat's Comments Signed-off-by: Varun Jain <[email protected]> * Fixing test cases Signed-off-by: Varun Jain <[email protected]> * Fixing test cases Signed-off-by: Varun Jain <[email protected]> * Fixing ReleaseLocktestcase Signed-off-by: Varun Jain <[email protected]> * Fixing ReleaseLocktestcase Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> * Bumping BWC version to 2.7 and Fixing xcontent imports (#322) * [Extensions] Add all fields of LockModel to RestGetLockAction response (#342) * Modifies the RestGetLockAction response to include all fields of the lock model object, rather than the lock model object itself Signed-off-by: Joshua Palis <[email protected]> * Removing unused fields Signed-off-by: Joshua Palis <[email protected]> * reverting field removal Signed-off-by: Joshua Palis <[email protected]> * Adding lockID to back to response Signed-off-by: Joshua Palis <[email protected]> * Adding checks to multinode get lock rest integration tests to ensure that all response fields are populated Signed-off-by: Joshua Palis <[email protected]> * fixing lock time parsing Signed-off-by: Joshua Palis <[email protected]> * Adds a new Response class to house serde logic for RestGetLockAction response Signed-off-by: Joshua Palis <[email protected]> * Moving parser.nextToken() within AcquireLockResponse.parse() Signed-off-by: Joshua Palis <[email protected]> * Implementing toXContentObject for AcquireLockRequest Signed-off-by: Joshua Palis <[email protected]> * Moving AcquireLockResponse to transpor package Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> * Increasing JobDetailsService request timeoufrom 10 to 15, since the initial job detail registration request will initialize the job details metadata index, which takes some time (#346) Signed-off-by: Joshua Palis <[email protected]> * Fixes serde logic for proxy scheduled jobrunner/parser requests/responses (#349) Signed-off-by: Joshua Palis <[email protected]> * Fixes serde logic for JobParameterRequest/JobRunnerRequest. Removes extra trimming of request bytes for the streaminput constructor for the JobParameter/RunnerRequest, as this is already trimmed by the SDK prior to forwarding the actionrequest to the transport action (#351) Signed-off-by: Joshua Palis <[email protected]> * [Extensions] Makes JobRunner/Parameter/Request/Response classes extend from ActionRequest/Response (#352) * Replaces ExtensionActionRequest class name with the JobParameter/RunnerRequest fully qualified class names, modifes JobParameter/Runner/Request/Response classes to extend from ActionRequest/Response Signed-off-by: Joshua Palis <[email protected]> * Removes ExtensionJobActionResponse and fixes affected test classes Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> * Consuming breaking changes from moving ExtensionActionRequest (#381) Signed-off-by: Sarat Vemulapalli <[email protected]> * spotless Signed-off-by: Joshua Palis <[email protected]> * Fixing apache imports for TestHelpers class Signed-off-by: Joshua Palis <[email protected]> * Modofies ODFERestTestCase to work with 2.x Signed-off-by: Joshua Palis <[email protected]> * Fixing wipeAllODFEIndices Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Co-authored-by: Varun Jain <[email protected]> Co-authored-by: Sarat Vemulapalli <[email protected]>

vibrantvarun added 5 commits February 6, 2023 17:03

Release lock API

57b8efb

Signed-off-by: Varun Jain <[email protected]>

Release Lock API

e968243

Signed-off-by: Varun Jain <[email protected]>

Release Lock API

54e1470

Signed-off-by: Varun Jain <[email protected]>

Release Lock API

2696968

Signed-off-by: Varun Jain <[email protected]>

Release Lock API

b40fccb

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun mentioned this pull request Feb 12, 2023

[Feature/extensions] Reformatting the imports opensearch-project/anomaly-detection#806

Merged

joshpalis marked this pull request as ready for review February 13, 2023 19:56

joshpalis requested a review from a team February 13, 2023 19:56

vibrantvarun added 2 commits February 13, 2023 11:57

Reformatting

9b706ee

Signed-off-by: Varun Jain <[email protected]>

Reformatting

65ed8e3

Signed-off-by: Varun Jain <[email protected]>

joshpalis reviewed Feb 13, 2023

View reviewed changes

src/test/java/org/opensearch/jobscheduler/multinode/ReleaseLockActionMultiNodeRestIT.java Show resolved Hide resolved

src/test/java/org/opensearch/jobscheduler/TestHelpers.java Outdated Show resolved Hide resolved

Reformatting

89b47bb

Signed-off-by: Varun Jain <[email protected]>

joshpalis requested review from saratvemulapalli and dbwiddis February 13, 2023 20:57

dbwiddis requested changes Feb 13, 2023

View reviewed changes

dbwiddis previously approved these changes Feb 13, 2023

View reviewed changes

dbwiddis requested a review from joshpalis February 13, 2023 22:45

Addressing Dan's Comments

a47c63a

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun dismissed dbwiddis’s stale review via a47c63a February 13, 2023 23:22

joshpalis requested a review from dbwiddis February 13, 2023 23:23

joshpalis reviewed Feb 13, 2023

View reviewed changes

dbwiddis previously approved these changes Feb 13, 2023

View reviewed changes

Addressing Dan's Comments

4fc06ee

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun dismissed dbwiddis’s stale review via 4fc06ee February 13, 2023 23:37

joshpalis previously approved these changes Feb 13, 2023

View reviewed changes

joshpalis requested a review from dbwiddis February 13, 2023 23:38

saratvemulapalli reviewed Feb 13, 2023

View reviewed changes

saratvemulapalli previously approved these changes Feb 13, 2023

View reviewed changes

Addressing Sarat's Comments

5fdfcd9

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun dismissed stale reviews from saratvemulapalli and joshpalis via 5fdfcd9 February 14, 2023 01:07

Addressing Sarat's Comments

570c40a

Signed-off-by: Varun Jain <[email protected]>

dbwiddis previously approved these changes Feb 14, 2023

View reviewed changes

Fixing test cases

c873e14

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun dismissed dbwiddis’s stale review via c873e14 February 14, 2023 18:48

vibrantvarun requested review from dbwiddis, joshpalis and saratvemulapalli February 14, 2023 19:17

joshpalis requested changes Feb 14, 2023

View reviewed changes

vibrantvarun added 2 commits February 14, 2023 11:54

Fixing test cases

8d79b83

Signed-off-by: Varun Jain <[email protected]>

Fixing ReleaseLocktestcase

d15a263

Signed-off-by: Varun Jain <[email protected]>

vibrantvarun requested a review from joshpalis February 14, 2023 21:18

Fixing ReleaseLocktestcase

c73b633

Signed-off-by: Varun Jain <[email protected]>

joshpalis approved these changes Feb 14, 2023

View reviewed changes

saratvemulapalli approved these changes Feb 15, 2023

View reviewed changes

saratvemulapalli merged commit 6448a32 into opensearch-project:main Feb 15, 2023

vibrantvarun deleted the ReleaseLockApi branch February 15, 2023 00:25

prudhvigodithi mentioned this pull request Jul 3, 2024

Update the job-scheduler plugin documentation with the list of supported API's #648

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Communication Mechanism Work Item 6 Release lock api #312

Communication Mechanism Work Item 6 Release lock api #312

vibrantvarun commented Feb 10, 2023 •

edited

Loading

codecov-commenter commented Feb 13, 2023 •

edited

Loading

joshpalis left a comment

vibrantvarun commented Feb 13, 2023 •

edited

Loading

dbwiddis left a comment

dbwiddis left a comment

joshpalis left a comment

joshpalis left a comment

saratvemulapalli Feb 13, 2023

vibrantvarun Feb 13, 2023

dbwiddis Feb 14, 2023

saratvemulapalli Feb 13, 2023

vibrantvarun Feb 13, 2023

saratvemulapalli Feb 13, 2023

vibrantvarun Feb 13, 2023

saratvemulapalli Feb 13, 2023 •

edited

Loading

vibrantvarun Feb 14, 2023

saratvemulapalli Feb 14, 2023

dbwiddis Feb 14, 2023

saratvemulapalli Feb 13, 2023

vibrantvarun Feb 13, 2023

saratvemulapalli Feb 13, 2023 •

edited

Loading

vibrantvarun Feb 13, 2023

saratvemulapalli left a comment

dbwiddis left a comment

dbwiddis Feb 14, 2023

vibrantvarun Feb 14, 2023

joshpalis left a comment

joshpalis left a comment

	builder.field("response", restResponseString);
	builder.field("release-lock", restResponseString);

Communication Mechanism Work Item 6 Release lock api #312

Communication Mechanism Work Item 6 Release lock api #312

Conversation

vibrantvarun commented Feb 10, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Feb 13, 2023 • edited Loading

Codecov Report

joshpalis left a comment

Choose a reason for hiding this comment

vibrantvarun commented Feb 13, 2023 • edited Loading

dbwiddis left a comment

Choose a reason for hiding this comment

dbwiddis left a comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saratvemulapalli Feb 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saratvemulapalli Feb 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saratvemulapalli left a comment

Choose a reason for hiding this comment

dbwiddis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

vibrantvarun commented Feb 10, 2023 •

edited

Loading

codecov-commenter commented Feb 13, 2023 •

edited

Loading

vibrantvarun commented Feb 13, 2023 •

edited

Loading

saratvemulapalli Feb 13, 2023 •

edited

Loading

saratvemulapalli Feb 13, 2023 •

edited

Loading