Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing thread sleep to 100,000 #294

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Increasing thread sleep to 100,000 #294

merged 1 commit into from
Jan 5, 2023

Conversation

joshpalis
Copy link
Member

Signed-off-by: Joshua Palis [email protected]

Description

There has been an increase of BWC test failures now that the windows CI workflow has been added. The source of the issue is the createBasicWatcherJob() method here that counts the number of records within a job index after the job has been executed. The job is configured to execute every minute, and after waiting for 80,000 ms, the test attempts to confirm that there is only 1 record within the index. This error is not reproducible locally, and I suspect that this may be a transient fault. In order to mitigate this issue, increasing the thread sleep to 100,000

Example build failure : https://github.com/opensearch-project/job-scheduler/actions/runs/3803814253/jobs/6470491899#step:4:1189

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis joshpalis requested a review from a team January 4, 2023 22:18
@codecov-commenter
Copy link

Codecov Report

Merging #294 (f17fea6) into main (140ffd3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #294   +/-   ##
=========================================
  Coverage     52.33%   52.33%           
  Complexity       65       65           
=========================================
  Files             8        8           
  Lines           449      449           
  Branches         50       50           
=========================================
  Hits            235      235           
  Misses          195      195           
  Partials         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshpalis joshpalis merged commit b67c000 into opensearch-project:main Jan 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 5, 2023
Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit b67c000)
joshpalis added a commit that referenced this pull request Jan 5, 2023
Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit b67c000)

Co-authored-by: Joshua Palis <[email protected]>
@qreshi
Copy link
Contributor

qreshi commented Jan 5, 2023

@joshpalis This seems a little strange. The helper method that indexes the document seems to be calling refresh already. It shouldn't even be taking 80,000ms for the document to be searchable. Are we sure there isn't something else impeding on the assertion (like the tests leaking and causing the index to be cleaned up)?

wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
…ch-project#295)

Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit b67c000)

Co-authored-by: Joshua Palis <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
…ch-project#295)

Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit b67c000)

Co-authored-by: Joshua Palis <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants