Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring spotlessApply for Job Scheduler #291

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Configuring spotlessApply for Job Scheduler #291

merged 2 commits into from
Dec 29, 2022

Conversation

joshpalis
Copy link
Member

Signed-off-by: Joshua Palis [email protected]

Description

Adds spotlessApply for Job Scheduler

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshpalis joshpalis requested review from dbwiddis, saratvemulapalli and a team December 29, 2022 21:50
Signed-off-by: Joshua Palis <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #291 (b27e681) into 2.x (1c2233d) will decrease coverage by 0.85%.
The diff coverage is 25.55%.

@@             Coverage Diff              @@
##                2.x     #291      +/-   ##
============================================
- Coverage     53.19%   52.33%   -0.86%     
  Complexity       65       65              
============================================
  Files             8        8              
  Lines           438      449      +11     
  Branches         50       50              
============================================
+ Hits            233      235       +2     
- Misses          186      195       +9     
  Partials         19       19              
Impacted Files Coverage Δ
...rg/opensearch/jobscheduler/JobSchedulerPlugin.java 36.53% <0.00%> (-0.72%) ⬇️
.../opensearch/jobscheduler/JobSchedulerSettings.java 85.71% <ø> (ø)
.../opensearch/jobscheduler/ScheduledJobProvider.java 80.00% <ø> (ø)
...arch/jobscheduler/scheduler/JobSchedulingInfo.java 79.16% <ø> (ø)
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.49% <20.58%> (-0.77%) ⬇️
...earch/jobscheduler/scheduler/ScheduledJobInfo.java 80.00% <40.00%> (ø)
...pensearch/jobscheduler/scheduler/JobScheduler.java 72.72% <50.00%> (-1.40%) ⬇️
...cheduler/LegacyOpenDistroJobSchedulerSettings.java 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dbwiddis dbwiddis merged commit ab73c97 into opensearch-project:2.x Dec 29, 2022
@joshpalis joshpalis deleted the spotless branch December 29, 2022 23:39
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
* Configuring spotlessApply for Job Scheduler

Signed-off-by: Joshua Palis <[email protected]>

* SpotlessApply

Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
* Configuring spotlessApply for Job Scheduler

Signed-off-by: Joshua Palis <[email protected]>

* SpotlessApply

Signed-off-by: Joshua Palis <[email protected]>

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants