Upload docker test cluster log #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
============================================
+ Coverage 75.55% 75.76% +0.20%
- Complexity 2842 2847 +5
============================================
Files 364 364
Lines 16263 16263
Branches 2343 2343
============================================
+ Hits 12288 12321 +33
+ Misses 2626 2600 -26
+ Partials 1349 1342 -7 |
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
requested review from
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep and
AWSHurneyt
as code owners
bowenlan-amzn
changed the title
lezzago
approved these changes
Oct 3, 2023
jowg-amazon
approved these changes
Oct 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Update test workflows to increase readability Signed-off-by: bowenlan-amzn <[email protected]> * Test if docker logs upload right Signed-off-by: bowenlan-amzn <[email protected]> * Add back if failure Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit a9ad1f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Update test workflows to increase readability * Test if docker logs upload right * Add back if failure --------- (cherry picked from commit a9ad1f6) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Joshua152
pushed a commit
to Joshua152/index-management
that referenced
this pull request
Oct 10, 2023
* Update test workflows to increase readability Signed-off-by: bowenlan-amzn <[email protected]> * Test if docker logs upload right Signed-off-by: bowenlan-amzn <[email protected]> * Add back if failure Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Docker test cannot upload the cluster log which is the docker log if failed. Now it can. Check this result https://github.com/opensearch-project/index-management/actions/runs/6366907682/job/17285043559?pr=964
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.