Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Shrink action Fix #735

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2a63f94 from #718

* Fixed issues of shrink action

Signed-off-by: Angie Zhang <[email protected]>

* Fixed node lock release error: request should use value of "_id" instead of "job_id"

Signed-off-by: Angie Zhang <[email protected]>

* Fix review comments

Signed-off-by: Angie Zhang <[email protected]>

* Fix build error

Signed-off-by: Angie Zhang <[email protected]>

* Update getShrinkLockID

Signed-off-by: Angie Zhang <[email protected]>

* Added debug logs for Shard Moving Decisions

Signed-off-by: Angie Zhang <[email protected]>

* Fix detekt error

Signed-off-by: Angie Zhang <[email protected]>

* Fix failed test cases due to renew lock error

Signed-off-by: Angie Zhang <[email protected]>

* Fix failed test cases due to lock job id error

Signed-off-by: Angie Zhang <[email protected]>

* Fix review comments

Signed-off-by: Angie Zhang <[email protected]>

---------

Signed-off-by: Angie Zhang <[email protected]>
(cherry picked from commit 2a63f94)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team April 10, 2023 16:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #735 (eeb7857) into main (8fe17c7) will decrease coverage by 0.20%.
The diff coverage is 51.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #735      +/-   ##
============================================
- Coverage     76.01%   75.82%   -0.20%     
+ Complexity     2663     2657       -6     
============================================
  Files           333      333              
  Lines         15400    15456      +56     
  Branches       2272     2282      +10     
============================================
+ Hits          11706    11719      +13     
- Misses         2376     2407      +31     
- Partials       1318     1330      +12     
Impacted Files Coverage Δ
...gement/indexstatemanagement/action/ShrinkAction.kt 69.11% <ø> (ø)
...atemanagement/step/shrink/WaitForMoveShardsStep.kt 49.23% <0.00%> (ø)
...exstatemanagement/step/shrink/WaitForShrinkStep.kt 42.00% <0.00%> (ø)
...atemanagement/step/shrink/AttemptMoveShardsStep.kt 57.70% <49.35%> (-2.72%) ⬇️
...exstatemanagement/step/shrink/AttemptShrinkStep.kt 59.42% <53.33%> (-1.30%) ⬇️
...ent/indexstatemanagement/step/shrink/ShrinkStep.kt 35.55% <60.00%> (-0.71%) ⬇️
...xmanagement/indexstatemanagement/util/StepUtils.kt 88.17% <100.00%> (+0.53%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Angie-Zhang Angie-Zhang merged commit eeeaac4 into main Apr 10, 2023
@github-actions github-actions bot deleted the backport/backport-718-to-main branch April 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants