CRUD api for long running operation notification config #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
Hailong-am
reviewed
Mar 30, 2023
...pensearch/indexmanagement/controlcenter/notification/action/delete/DeleteLRONConfigAction.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: zhichao-aws <[email protected]>
Hailong-am
reviewed
Mar 30, 2023
...search/indexmanagement/controlcenter/notification/action/get/TransportGetLRONConfigAction.kt
Outdated
Show resolved
Hide resolved
...opensearch/indexmanagement/controlcenter/notification/action/index/IndexLRONConfigRequest.kt
Outdated
Show resolved
Hide resolved
...ch/indexmanagement/controlcenter/notification/action/index/TransportIndexLRONConfigAction.kt
Show resolved
Hide resolved
...ch/indexmanagement/controlcenter/notification/action/index/TransportIndexLRONConfigAction.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/controlcenter/notification/model/LRONConfig.kt
Outdated
Show resolved
Hide resolved
...in/org/opensearch/indexmanagement/controlcenter/notification/LRONConfigSecurityBehaviorIT.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #722 +/- ##
============================================
+ Coverage 75.42% 75.64% +0.22%
- Complexity 2593 2699 +106
============================================
Files 335 353 +18
Lines 15176 15622 +446
Branches 2188 2233 +45
============================================
+ Hits 11446 11818 +372
- Misses 2451 2506 +55
- Partials 1279 1298 +19
|
gaobinlong
reviewed
Mar 30, 2023
...org/opensearch/indexmanagement/controlcenter/notification/action/get/GetLRONConfigRequest.kt
Outdated
Show resolved
Hide resolved
...rg/opensearch/indexmanagement/controlcenter/notification/action/get/GetLRONConfigResponse.kt
Outdated
Show resolved
Hide resolved
...ensearch/indexmanagement/controlcenter/notification/action/delete/DeleteLRONConfigRequest.kt
Show resolved
Hide resolved
...search/indexmanagement/controlcenter/notification/action/get/TransportGetLRONConfigAction.kt
Outdated
Show resolved
Hide resolved
...ch/indexmanagement/controlcenter/notification/action/index/TransportIndexLRONConfigAction.kt
Show resolved
Hide resolved
...ch/indexmanagement/controlcenter/notification/action/index/TransportIndexLRONConfigAction.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Hailong-am
previously approved these changes
Apr 3, 2023
zhichao-aws
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni and
xluo-aws
as code owners
Signed-off-by: zhichao-aws <[email protected]>
|
docker security test fail due to docker image is not update to date which not includ |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
* notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 96f7380)
Hailong-am
pushed a commit
that referenced
this pull request
May 25, 2023
#791) * CRUD api for long running operation notification config (#722) * notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 96f7380) * fix test code apache http package version Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]>
petardz
pushed a commit
to petardz/index-management
that referenced
this pull request
May 31, 2023
…roject#722) * notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]>
petardz
pushed a commit
to petardz/index-management
that referenced
this pull request
May 31, 2023
…roject#722) * notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]>
ronnaksaxena
pushed a commit
to ronnaksaxena/index-management
that referenced
this pull request
Jul 19, 2023
opensearch-project#791) * CRUD api for long running operation notification config (opensearch-project#722) * notification crud api Signed-off-by: zhichao-aws <[email protected]> * changes based on comments; add tests Signed-off-by: zhichao-aws <[email protected]> * changes for comment Signed-off-by: zhichao-aws <[email protected]> * change behavior for get action index not exists, fix test cases Signed-off-by: zhichao-aws <[email protected]> * fix weak password for changes in security plugin Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 96f7380) * fix test code apache http package version Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#700
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.